You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Yichi Lu <yi...@sungard.com> on 2013/11/22 16:32:06 UTC

Review Request 15787: Improvement CLOUDSTACK-5231: Add helper texts for registering templates

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15787/
-----------------------------------------------------------

Review request for cloudstack, Ian Duffy and Rajani Karuturi.


Bugs: 5231
    https://issues.apache.org/jira/browse/5231


Repository: cloudstack-git


Description
-------

When registering templates, two checkboxes: dynamically scalable and routing, are missing helper texts. For dynamically scalable checkbox, add helper text: 'Check this if the template contains XS/VMWare tools to support dynamic scaling of VM cpu/memory.'. For routing, 'Check this if the template is used for deploying router.'.


Diffs
-----

  ui/scripts/docs.js a3151b1 
  ui/scripts/templates.js f45c2d2 

Diff: https://reviews.apache.org/r/15787/diff/


Testing
-------

verified on cloudstack GUI, Templates, Register template.


Thanks,

Yichi Lu


Re: Review Request 15787: Improvement CLOUDSTACK-5231: Add helper texts for registering templates

Posted by Rajani Karuturi <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15787/#review29287
-----------------------------------------------------------

Ship it!


Ship It!

- Rajani Karuturi


On Nov. 22, 2013, 3:32 p.m., Yichi Lu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15787/
> -----------------------------------------------------------
> 
> (Updated Nov. 22, 2013, 3:32 p.m.)
> 
> 
> Review request for cloudstack, Ian Duffy and Rajani Karuturi.
> 
> 
> Bugs: 5231
>     https://issues.apache.org/jira/browse/5231
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> When registering templates, two checkboxes: dynamically scalable and routing, are missing helper texts. For dynamically scalable checkbox, add helper text: 'Check this if the template contains XS/VMWare tools to support dynamic scaling of VM cpu/memory.'. For routing, 'Check this if the template is used for deploying router.'.
> 
> 
> Diffs
> -----
> 
>   ui/scripts/docs.js a3151b1 
>   ui/scripts/templates.js f45c2d2 
> 
> Diff: https://reviews.apache.org/r/15787/diff/
> 
> 
> Testing
> -------
> 
> verified on cloudstack GUI, Templates, Register template.
> 
> 
> Thanks,
> 
> Yichi Lu
> 
>


Re: Review Request 15787: Improvement CLOUDSTACK-5231: Add helper texts for registering templates

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15787/#review29290
-----------------------------------------------------------


Commit 8e580cc41184eac53969267234114d9d8ea23006 in branch refs/heads/master from Yichi Lu
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=8e580cc ]

CLOUDSTACK-5231: add helper messages for DynamicallyScalable and Routing


- ASF Subversion and Git Services


On Nov. 22, 2013, 3:32 p.m., Yichi Lu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15787/
> -----------------------------------------------------------
> 
> (Updated Nov. 22, 2013, 3:32 p.m.)
> 
> 
> Review request for cloudstack, Ian Duffy and Rajani Karuturi.
> 
> 
> Bugs: 5231
>     https://issues.apache.org/jira/browse/5231
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> When registering templates, two checkboxes: dynamically scalable and routing, are missing helper texts. For dynamically scalable checkbox, add helper text: 'Check this if the template contains XS/VMWare tools to support dynamic scaling of VM cpu/memory.'. For routing, 'Check this if the template is used for deploying router.'.
> 
> 
> Diffs
> -----
> 
>   ui/scripts/docs.js a3151b1 
>   ui/scripts/templates.js f45c2d2 
> 
> Diff: https://reviews.apache.org/r/15787/diff/
> 
> 
> Testing
> -------
> 
> verified on cloudstack GUI, Templates, Register template.
> 
> 
> Thanks,
> 
> Yichi Lu
> 
>


Re: Review Request 15787: Improvement CLOUDSTACK-5231: Add helper texts for registering templates

Posted by daan Hoogland <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15787/#review29292
-----------------------------------------------------------

Ship it!


8e580cc41184eac53969267234114d9d8ea23006

(had to edit blame info - please use your email next time)

- daan Hoogland


On Nov. 22, 2013, 3:32 p.m., Yichi Lu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15787/
> -----------------------------------------------------------
> 
> (Updated Nov. 22, 2013, 3:32 p.m.)
> 
> 
> Review request for cloudstack, Ian Duffy and Rajani Karuturi.
> 
> 
> Bugs: 5231
>     https://issues.apache.org/jira/browse/5231
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> When registering templates, two checkboxes: dynamically scalable and routing, are missing helper texts. For dynamically scalable checkbox, add helper text: 'Check this if the template contains XS/VMWare tools to support dynamic scaling of VM cpu/memory.'. For routing, 'Check this if the template is used for deploying router.'.
> 
> 
> Diffs
> -----
> 
>   ui/scripts/docs.js a3151b1 
>   ui/scripts/templates.js f45c2d2 
> 
> Diff: https://reviews.apache.org/r/15787/diff/
> 
> 
> Testing
> -------
> 
> verified on cloudstack GUI, Templates, Register template.
> 
> 
> Thanks,
> 
> Yichi Lu
> 
>