[jira] [Comment Edited] (HBASE-21466) WALProcedureStore uses wrong FileSystem if wal.dir is not under rootdir

["Tak Lon (Stephen) Wu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-21466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16684150#comment-16684150 ] 

Tak Lon (Stephen) Wu edited comment on HBASE-21466 at 11/12/18 5:54 PM:
------------------------------------------------------------------------

+1 (non-binding)

[~yuzhihong@gmail.com] Thanks for fixing this bug, I have two minor comments otherwise looks good to me.

{quote}
+    LOG.debug("wal fs " + fs + " for " + walDir);
{quote}

Do you think we should remove this debug message or write a better message {{LOG.debug("WAL directory " + walDir.getName() + " is using filesystem " + fs);}}?

{quote}
+    CommonFSUtils.setWALRootDir(conf, new Path(conf.get("fs.defaultFS"), "/tmp/wal"));
{quote}

[minor] there are two lines of setting the WAL's root directory, but I'm wondered if {{/tmp/wal}} should be {{tmp/wal}} without an file separator {{/}}? 


was (Author: taklwu):
[~yuzhihong@gmail.com] Thanks for fixing this bug, I have two minor comments otherwise looks good to me.

{quote}
+    LOG.debug("wal fs " + fs + " for " + walDir);
{quote}

Do you think we should remove this debug message or write a better message {{LOG.debug("WAL directory " + walDir.getName() + " is using filesystem " + fs);}}?

{quote}
+    CommonFSUtils.setWALRootDir(conf, new Path(conf.get("fs.defaultFS"), "/tmp/wal"));
{quote}

[minor] there are two lines of setting the WAL's root directory, but I'm wondered if {{/tmp/wal}} should be {{tmp/wal}} without an file separator {{/}}? 

> WALProcedureStore uses wrong FileSystem if wal.dir is not under rootdir
> -----------------------------------------------------------------------
>
>                 Key: HBASE-21466
>                 URL: https://issues.apache.org/jira/browse/HBASE-21466
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>            Priority: Major
>         Attachments: 21466.v2.txt
>
>
> In WALProcedureStore ctor , the fs field is initialized this way:
> {code}
>     this.fs = walDir.getFileSystem(conf);
> {code}
> However, when wal.dir is not under rootdir, the above would return wrong FileSystem.
> In the modified TestMasterProcedureEvents, without fix, the master wouldn't initialize.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)