You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Qifan Chen (Code Review)" <ge...@cloudera.org> on 2020/10/12 16:15:53 UTC

[Impala-ASF-CR] IMPALA-9232 Potential overflow in serializeThriftMsg 

Qifan Chen has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16584


Change subject: IMPALA-9232 Potential overflow in serializeThriftMsg
......................................................................

IMPALA-9232 Potential overflow in serializeThriftMsg

This fix added a sanity check to assure the length of the buffer
holding a serialized object does not go over INT_MAX bytes.

Testing:
1. Unit testing;
2. Ran Core tests successfully.

Change-Id: Ie76028acea84dbe0e88518dae60aaf7e7ca55e9e
---
M be/src/rpc/jni-thrift-util.h
1 file changed, 9 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/84/16584/1
-- 
To view, visit http://gerrit.cloudera.org:8080/16584
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie76028acea84dbe0e88518dae60aaf7e7ca55e9e
Gerrit-Change-Number: 16584
Gerrit-PatchSet: 1
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-9232 Potential overflow in serializeThriftMsg

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16584 )

Change subject: IMPALA-9232 Potential overflow in serializeThriftMsg
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6556/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/16584
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie76028acea84dbe0e88518dae60aaf7e7ca55e9e
Gerrit-Change-Number: 16584
Gerrit-PatchSet: 2
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 13 Oct 2020 17:59:03 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9232 Potential overflow in serializeThriftMsg

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16584 )

Change subject: IMPALA-9232 Potential overflow in serializeThriftMsg
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6546/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/16584
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie76028acea84dbe0e88518dae60aaf7e7ca55e9e
Gerrit-Change-Number: 16584
Gerrit-PatchSet: 2
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 12 Oct 2020 17:35:40 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9232 Potential overflow in serializeThriftMsg

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16584 )

Change subject: IMPALA-9232 Potential overflow in serializeThriftMsg
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6570/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/16584
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie76028acea84dbe0e88518dae60aaf7e7ca55e9e
Gerrit-Change-Number: 16584
Gerrit-PatchSet: 3
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 14 Oct 2020 18:01:26 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9232 Potential overflow in serializeThriftMsg

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16584 )

Change subject: IMPALA-9232 Potential overflow in serializeThriftMsg
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/7456/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/16584
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie76028acea84dbe0e88518dae60aaf7e7ca55e9e
Gerrit-Change-Number: 16584
Gerrit-PatchSet: 3
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 14 Oct 2020 18:11:04 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9232 Potential overflow in serializeThriftMsg

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16584 )

Change subject: IMPALA-9232 Potential overflow in serializeThriftMsg
......................................................................


Patch Set 2: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/6546/


-- 
To view, visit http://gerrit.cloudera.org:8080/16584
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie76028acea84dbe0e88518dae60aaf7e7ca55e9e
Gerrit-Change-Number: 16584
Gerrit-PatchSet: 2
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 12 Oct 2020 22:55:59 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9232 Potential overflow in serializeThriftMsg

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16584 )

Change subject: IMPALA-9232 Potential overflow in serializeThriftMsg
......................................................................


Patch Set 2:

I think this was IMPALA-9815


-- 
To view, visit http://gerrit.cloudera.org:8080/16584
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie76028acea84dbe0e88518dae60aaf7e7ca55e9e
Gerrit-Change-Number: 16584
Gerrit-PatchSet: 2
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 13 Oct 2020 00:28:10 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9232 Potential overflow in serializeThriftMsg

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16584 )

Change subject: IMPALA-9232 Potential overflow in serializeThriftMsg
......................................................................


Patch Set 3: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/16584
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie76028acea84dbe0e88518dae60aaf7e7ca55e9e
Gerrit-Change-Number: 16584
Gerrit-PatchSet: 3
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 14 Oct 2020 23:25:40 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9232 Potential overflow in serializeThriftMsg

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16584 )

Change subject: IMPALA-9232 Potential overflow in serializeThriftMsg
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/16584
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie76028acea84dbe0e88518dae60aaf7e7ca55e9e
Gerrit-Change-Number: 16584
Gerrit-PatchSet: 2
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 12 Oct 2020 17:35:28 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9232 Potential overflow in serializeThriftMsg

Posted by "Qifan Chen (Code Review)" <ge...@cloudera.org>.
Qifan Chen has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/16584 )

Change subject: IMPALA-9232 Potential overflow in serializeThriftMsg
......................................................................

IMPALA-9232 Potential overflow in serializeThriftMsg

This fix added a sanity check to assure the length of the buffer
holding a serialized object does not go over INT_MAX bytes.

Testing:
1. Unit testing;
2. Ran Core tests successfully.

Change-Id: Ie76028acea84dbe0e88518dae60aaf7e7ca55e9e
---
M be/src/rpc/jni-thrift-util.h
1 file changed, 8 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/84/16584/2
-- 
To view, visit http://gerrit.cloudera.org:8080/16584
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie76028acea84dbe0e88518dae60aaf7e7ca55e9e
Gerrit-Change-Number: 16584
Gerrit-PatchSet: 2
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-9232 Potential overflow in serializeThriftMsg

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16584 )

Change subject: IMPALA-9232 Potential overflow in serializeThriftMsg
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/7430/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/16584
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie76028acea84dbe0e88518dae60aaf7e7ca55e9e
Gerrit-Change-Number: 16584
Gerrit-PatchSet: 2
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 12 Oct 2020 17:30:07 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9232 Potential overflow in serializeThriftMsg

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16584 )

Change subject: IMPALA-9232 Potential overflow in serializeThriftMsg
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/7429/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/16584
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie76028acea84dbe0e88518dae60aaf7e7ca55e9e
Gerrit-Change-Number: 16584
Gerrit-PatchSet: 1
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 12 Oct 2020 16:38:04 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9232 Potential overflow in serializeThriftMsg

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16584 )

Change subject: IMPALA-9232 Potential overflow in serializeThriftMsg
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6549/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/16584
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie76028acea84dbe0e88518dae60aaf7e7ca55e9e
Gerrit-Change-Number: 16584
Gerrit-PatchSet: 2
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 13 Oct 2020 00:28:23 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9232 Potential overflow in serializeThriftMsg

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16584 )

Change subject: IMPALA-9232 Potential overflow in serializeThriftMsg
......................................................................


Patch Set 2:

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/6556/


-- 
To view, visit http://gerrit.cloudera.org:8080/16584
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie76028acea84dbe0e88518dae60aaf7e7ca55e9e
Gerrit-Change-Number: 16584
Gerrit-PatchSet: 2
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 13 Oct 2020 23:20:48 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9232 Potential overflow in serializeThriftMsg

Posted by "Qifan Chen (Code Review)" <ge...@cloudera.org>.
Qifan Chen has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/16584 )

Change subject: IMPALA-9232 Potential overflow in serializeThriftMsg
......................................................................

IMPALA-9232 Potential overflow in serializeThriftMsg

This fix added a sanity check to assure the length of the buffer
holding a serialized object does not go over INT_MAX bytes.

Testing:
1. Unit testing;
2. Ran Core tests successfully.

Change-Id: Ie76028acea84dbe0e88518dae60aaf7e7ca55e9e
---
M be/src/rpc/jni-thrift-util.h
1 file changed, 8 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/84/16584/3
-- 
To view, visit http://gerrit.cloudera.org:8080/16584
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie76028acea84dbe0e88518dae60aaf7e7ca55e9e
Gerrit-Change-Number: 16584
Gerrit-PatchSet: 3
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-9232 Potential overflow in serializeThriftMsg

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16584 )

Change subject: IMPALA-9232 Potential overflow in serializeThriftMsg
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/16584
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie76028acea84dbe0e88518dae60aaf7e7ca55e9e
Gerrit-Change-Number: 16584
Gerrit-PatchSet: 3
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 14 Oct 2020 18:01:15 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9232 Potential overflow in serializeThriftMsg

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16584 )

Change subject: IMPALA-9232 Potential overflow in serializeThriftMsg
......................................................................

IMPALA-9232 Potential overflow in serializeThriftMsg

This fix added a sanity check to assure the length of the buffer
holding a serialized object does not go over INT_MAX bytes.

Testing:
1. Unit testing;
2. Ran Core tests successfully.

Change-Id: Ie76028acea84dbe0e88518dae60aaf7e7ca55e9e
Reviewed-on: http://gerrit.cloudera.org:8080/16584
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/rpc/jni-thrift-util.h
1 file changed, 8 insertions(+), 0 deletions(-)

Approvals:
  Tim Armstrong: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/16584
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie76028acea84dbe0e88518dae60aaf7e7ca55e9e
Gerrit-Change-Number: 16584
Gerrit-PatchSet: 4
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-9232 Potential overflow in serializeThriftMsg

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16584 )

Change subject: IMPALA-9232 Potential overflow in serializeThriftMsg
......................................................................


Patch Set 1:

(1 comment)

Thanks for catching this, these overflows can be a headache to find otherwise. I have a nit about how to to the string substitution, but after that I'll +2

http://gerrit.cloudera.org:8080/#/c/16584/1/be/src/rpc/jni-thrift-util.h
File be/src/rpc/jni-thrift-util.h:

http://gerrit.cloudera.org:8080/#/c/16584/1/be/src/rpc/jni-thrift-util.h@40
PS1, Line 40:   if (size > INT_MAX) {
This is a good catch.

One nit: we try to use strings::Substitute() from gutil/strings/substitute.h instead of stringstream where possible, i.e. when substituting values into a fixed string template.



-- 
To view, visit http://gerrit.cloudera.org:8080/16584
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie76028acea84dbe0e88518dae60aaf7e7ca55e9e
Gerrit-Change-Number: 16584
Gerrit-PatchSet: 1
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 12 Oct 2020 16:32:51 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-9232 Potential overflow in serializeThriftMsg

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16584 )

Change subject: IMPALA-9232 Potential overflow in serializeThriftMsg
......................................................................


Patch Set 2:

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/6549/


-- 
To view, visit http://gerrit.cloudera.org:8080/16584
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie76028acea84dbe0e88518dae60aaf7e7ca55e9e
Gerrit-Change-Number: 16584
Gerrit-PatchSet: 2
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 13 Oct 2020 05:49:25 +0000
Gerrit-HasComments: No