[GitHub] [servicecomb-service-center] tianxiaoliang commented on a change in pull request #886: [SCB-2094] Extract some common functions into mongo/util

[GitBox <gi...@apache.org>]

tianxiaoliang commented on a change in pull request #886:
URL: https://github.com/apache/servicecomb-service-center/pull/886#discussion_r590147778



##########
File path: datasource/mongo/util/schema_util.go
##########
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package util
+
+import (
+	"context"
+
+	"github.com/go-chassis/cari/discovery"
+	"go.mongodb.org/mongo-driver/bson"
+	"go.mongodb.org/mongo-driver/mongo/options"
+
+	"github.com/apache/servicecomb-service-center/datasource/mongo/client"
+	"github.com/apache/servicecomb-service-center/datasource/mongo/db"
+	"github.com/apache/servicecomb-service-center/pkg/util"
+)
+
+func GetSchema(ctx context.Context, filter bson.M) (*db.Schema, error) {

Review comment:
       我期望工具类不该是有数据库操作的
   或者是通用数据库操作，不带业务逻辑
   比如创建数据库视图，这叫工具类
   比如别对业务数据某个字段大小，这也是工具




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org