[jira] [Commented] (LUCENE-10299) investigate prefix/wildcard perf drop in nightly benchmarks

["Robert Muir (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-10299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17455991#comment-17455991 ] 

Robert Muir commented on LUCENE-10299:
--------------------------------------

Here are the list of commits in between the benchmark runs where the perf dropped: https://github.com/apache/lucene/compare/ec57641ea5940270ff7eb08536c9050a050adf1f...68e94c959729dee6f32b1c6fca1a5e4902a9fa51

> investigate prefix/wildcard perf drop in nightly benchmarks
> -----------------------------------------------------------
>
>                 Key: LUCENE-10299
>                 URL: https://issues.apache.org/jira/browse/LUCENE-10299
>             Project: Lucene - Core
>          Issue Type: Task
>            Reporter: Robert Muir
>            Priority: Major
>
> Recently the prefix/wildcard dropped. As these are super simple and not impacted by cleanups being done around RegExp, I think instead the perf-difference is in the guts of MultiTermQuery where it uses DocIdSetBuilder?
> *note that I haven't confirmed this and it is just a suspicion*
> So I think it may be LUCENE-10289 changes? e.g. doing loops with {{long}} instead of {{int}} like before, we know these are slower in java.
> I will admit, I'm a bit confused why we made this change since lucene docids can only be {{int}}.
> Maybe we get the performance back for free, with JDK18/19 which are optimizing loops on {{long}} better? So I'm not arguing that we burn a bunch of time to fix this, but just opening the issue.
> cc [~ivera]



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org