Re: [PR] optimize gc [thrift]

["ctubbsii (via GitHub)" <gi...@apache.org>]

ctubbsii commented on code in PR #3017:
URL: https://github.com/apache/thrift/pull/3017#discussion_r1717586286


##########
lib/java/src/main/java/org/apache/thrift/TServiceClient.java:
##########
@@ -93,4 +95,12 @@ protected void receiveBase(TBase<?, ?> result, String methodName) throws TExcept
     result.read(iprot_);
     iprot_.readMessageEnd();
   }
+
+  protected void after() {
+    TTransport transport = this.iprot_.getTransport();
+    if (transport instanceof TFramedTransport) {
+      TFramedTransport framedTransport = (TFramedTransport) transport;
+      framedTransport.clear();

Review Comment:
   This can be simplified
   
   ```suggestion
         ((TFramedTransport) transport).clear();
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org