You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Mryange (via GitHub)" <gi...@apache.org> on 2025/04/24 06:06:54 UTC
[PR] [chore](scan) Remove unused code in ScanLocalState [doris]
Mryange opened a new pull request, #50373:
URL: https://github.com/apache/doris/pull/50373
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](scan) Remove unused code in ScanLocalState [doris]
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #50373:
URL: https://github.com/apache/doris/pull/50373#issuecomment-2826484243
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](scan) Remove unused code in ScanLocalState [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50373:
URL: https://github.com/apache/doris/pull/50373#issuecomment-2826540093
<details>
<summary>TPC-DS: <b>Total hot run time: 192611 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 17e20e8136820ea9e465386bfe2a2887a12b9346, data reload: false
query1 1415 1068 1047 1047
query2 6224 1855 1763 1763
query3 11045 4580 4612 4580
query4 56520 24455 23750 23750
query5 5249 500 457 457
query6 388 204 194 194
query7 5074 504 278 278
query8 338 254 276 254
query9 6902 2595 2592 2592
query10 427 333 270 270
query11 15415 15138 14873 14873
query12 159 110 105 105
query13 1202 527 411 411
query14 10163 6359 6397 6359
query15 212 199 180 180
query16 7168 671 479 479
query17 1087 763 614 614
query18 1800 428 326 326
query19 199 207 171 171
query20 128 134 121 121
query21 209 124 106 106
query22 4313 4344 4254 4254
query23 34189 33532 34013 33532
query24 6620 2449 2414 2414
query25 470 464 395 395
query26 710 289 159 159
query27 2650 509 340 340
query28 3967 2185 2156 2156
query29 597 553 443 443
query30 284 221 204 204
query31 879 871 790 790
query32 73 67 64 64
query33 459 371 304 304
query34 766 857 528 528
query35 798 830 749 749
query36 953 978 903 903
query37 115 96 72 72
query38 4129 4174 4256 4174
query39 1494 1447 1421 1421
query40 218 117 107 107
query41 54 52 52 52
query42 118 111 114 111
query43 502 518 483 483
query44 1335 834 824 824
query45 178 178 171 171
query46 840 1035 657 657
query47 1863 1846 1768 1768
query48 387 417 318 318
query49 694 535 433 433
query50 668 701 407 407
query51 4278 4158 4200 4158
query52 114 112 102 102
query53 232 260 186 186
query54 586 591 539 539
query55 86 85 85 85
query56 310 294 288 288
query57 1221 1177 1071 1071
query58 251 247 251 247
query59 2527 2730 2529 2529
query60 325 319 299 299
query61 129 124 126 124
query62 746 717 640 640
query63 223 187 180 180
query64 1701 1048 679 679
query65 4329 4231 4237 4231
query66 725 401 306 306
query67 15535 15595 15124 15124
query68 7644 903 527 527
query69 534 299 263 263
query70 1187 1119 1117 1117
query71 500 333 292 292
query72 5570 4735 4868 4735
query73 1262 651 354 354
query74 9166 9066 8972 8972
query75 3823 3230 2685 2685
query76 4247 1195 752 752
query77 648 381 289 289
query78 9899 9974 9245 9245
query79 6610 829 568 568
query80 673 508 442 442
query81 484 253 224 224
query82 725 131 96 96
query83 349 255 237 237
query84 291 105 94 94
query85 808 350 317 317
query86 379 325 288 288
query87 4398 4332 4280 4280
query88 3400 2251 2238 2238
query89 459 320 283 283
query90 1914 209 288 209
query91 143 140 112 112
query92 79 64 60 60
query93 3045 955 576 576
query94 683 417 310 310
query95 362 292 279 279
query96 491 583 278 278
query97 3209 3241 3088 3088
query98 225 207 197 197
query99 1415 1433 1253 1253
Total cold run time: 309587 ms
Total hot run time: 192611 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](scan) Remove unused code in ScanLocalState [doris]
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange closed pull request #50373: [chore](scan) Remove unused code in ScanLocalState
URL: https://github.com/apache/doris/pull/50373
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](scan) Remove unused code in ScanLocalState [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50373:
URL: https://github.com/apache/doris/pull/50373#issuecomment-2826517054
<details>
<summary>TPC-H: <b>Total hot run time: 33876 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 17e20e8136820ea9e465386bfe2a2887a12b9346, data reload: false
------ Round 1 ----------------------------------
q1 25964 5086 5035 5035
q2 2085 276 188 188
q3 10390 1229 691 691
q4 10219 1012 541 541
q5 7578 2343 2347 2343
q6 178 159 134 134
q7 931 779 604 604
q8 9322 1242 1022 1022
q9 6732 5065 5063 5063
q10 6783 2321 1875 1875
q11 489 290 272 272
q12 346 349 219 219
q13 17770 3779 3142 3142
q14 227 226 212 212
q15 533 481 494 481
q16 445 452 404 404
q17 574 861 356 356
q18 7587 7157 7007 7007
q19 1084 948 558 558
q20 324 342 230 230
q21 4176 3417 2522 2522
q22 1038 1025 977 977
Total cold run time: 114775 ms
Total hot run time: 33876 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5186 5384 5098 5098
q2 240 328 232 232
q3 2109 2683 2297 2297
q4 1428 1819 1387 1387
q5 4486 4452 4460 4452
q6 231 175 135 135
q7 1970 1918 1749 1749
q8 2592 2535 2528 2528
q9 7339 7033 7163 7033
q10 2950 3181 2713 2713
q11 573 537 497 497
q12 708 767 609 609
q13 3556 3910 3333 3333
q14 305 294 284 284
q15 522 478 485 478
q16 484 516 468 468
q17 1155 1526 1425 1425
q18 7763 7532 7483 7483
q19 791 777 934 777
q20 1923 1959 1861 1861
q21 5423 4836 4785 4785
q22 1096 1040 1054 1040
Total cold run time: 52830 ms
Total hot run time: 50664 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](scan) Remove unused code in ScanLocalState [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50373:
URL: https://github.com/apache/doris/pull/50373#issuecomment-2826550576
<details>
<summary>ClickBench: <b>Total hot run time: 29.8 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 17e20e8136820ea9e465386bfe2a2887a12b9346, data reload: false
query1 0.04 0.05 0.04
query2 0.12 0.11 0.10
query3 0.25 0.19 0.19
query4 1.60 0.20 0.11
query5 0.56 0.56 0.56
query6 1.21 0.72 0.72
query7 0.02 0.02 0.01
query8 0.04 0.03 0.04
query9 0.57 0.52 0.51
query10 0.57 0.57 0.57
query11 0.16 0.10 0.11
query12 0.14 0.11 0.12
query13 0.61 0.60 0.61
query14 1.16 1.20 1.19
query15 0.88 0.84 0.87
query16 0.39 0.39 0.39
query17 1.03 1.02 1.06
query18 0.21 0.19 0.20
query19 1.88 1.85 1.82
query20 0.01 0.01 0.02
query21 15.39 0.93 0.56
query22 0.75 1.08 0.76
query23 14.90 1.42 0.63
query24 6.85 1.68 0.99
query25 0.46 0.25 0.06
query26 0.51 0.17 0.14
query27 0.05 0.06 0.05
query28 10.21 0.91 0.43
query29 12.52 4.07 3.34
query30 0.26 0.09 0.07
query31 2.81 0.59 0.39
query32 3.24 0.56 0.48
query33 3.10 2.99 3.06
query34 15.78 5.09 4.47
query35 4.49 4.51 4.53
query36 0.67 0.50 0.48
query37 0.09 0.07 0.07
query38 0.06 0.04 0.04
query39 0.03 0.02 0.02
query40 0.18 0.14 0.14
query41 0.08 0.03 0.02
query42 0.03 0.03 0.02
query43 0.03 0.03 0.03
Total cold run time: 103.94 s
Total hot run time: 29.8 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](scan) Remove unused code in ScanLocalState [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #50373:
URL: https://github.com/apache/doris/pull/50373#issuecomment-2826484136
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org