[jira] [Resolved] (DIRMINA-840) Logic Error in ByteArrayPool implementation

["Emmanuel Lecharny (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/DIRMINA-840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Emmanuel Lecharny resolved DIRMINA-840.
---------------------------------------

    Resolution: Fixed

Fixed with http://svn.apache.org/viewvc?rev=1359091&view=rev

many thanks !
                
> Logic Error in ByteArrayPool implementation
> -------------------------------------------
>
>                 Key: DIRMINA-840
>                 URL: https://issues.apache.org/jira/browse/DIRMINA-840
>             Project: MINA
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.0.4
>            Reporter: Fei Wang
>            Priority: Minor
>   Original Estimate: 0.1h
>  Remaining Estimate: 0.1h
>
> The is some logical error in ByteArrayPool#create(int size). 
> The two lines below should be changed to 
>             if (!freeBuffers.isEmpty()) {
>                 DirectBufferByteArray ba = freeBuffers.get(bits).pop();
>             if (!freeBuffers.get(bits).isEmpty()) {
>                 DirectBufferByteArray ba = freeBuffers.get(bits).pop();

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira