You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "wu-sheng (via GitHub)" <gi...@apache.org> on 2026/06/28 15:25:15 UTC
[PR] Satellite series labels, K8S_SERVICE network profiling, and async/pprof create-dialog fixes [skywalking-horizon-ui]
wu-sheng opened a new pull request, #86:
URL: https://github.com/apache/skywalking-horizon-ui/pull/86
## Why
A live-review pass against the public demo OAP surfaced a cluster of small defects in the dashboard render path and the per-layer profiling tabs, plus one missing capability. This bundles them.
## What
**Dashboards**
- **Satellite so11y series were all labelled `all`.** The dashboard parser named each labeled series off the *last* metric label. The Satellite event/queue metrics carry two labels — `pipe` (the series identity) and `status` (a constant aggregation dim whose value is `all`/`success`) — so every series collapsed onto the constant. Now named by the labels that *vary* across the result, dropping constant dims. Fixes Receive/Fetch Events, Queue Input/Output and the queue_io prefix; percentile (`p`), `queue_used` (single `pipeline`) and unlabeled series are unchanged.
**Profiling**
- **K8S_SERVICE gains a Network Profiling tab** (Rover eBPF, the same capability Mesh has), documented on the layer page.
- **Create dialogs**: the post-create hint counts down to a single list refresh (`refreshing in Ns`) instead of an opaque `N/4` counter; **Escape** now closes the Async and pprof create dialogs (parity with Trace/eBPF/Network); **Analyze** stays disabled until at least one instance is selected (Async, pprof).
- **Async event-type picker** is derived from the selected task's captured events — only the JFR trees those events actually produce — instead of a static list of all five. Drops `PROFILER_LIVE_OBJECT` (no create-modal event produces it; needs async-profiler `--live`) and allocation types on non-ALLOC tasks, which rendered an empty graph. Mirrors booster-ui's behaviour.
## Validation
- `type-check` (both), `lint` + source-budget, **162 BFF + 116 UI** unit tests, `i18n:validate`, `build` (ui + bff), `license-check` — all green.
- Live against the public demo OAP: the satellite parser is unit-tested against the real wire label shape (`{pipe, status='all'}`); headless Chrome confirmed Esc closes the Async/pprof create dialogs and the Async event-type dropdown shows exactly the 4 JFR types the demo's `agent::rating` task captured, with `PROFILER_LIVE_OBJECT` gone.
- The K8S_SERVICE `networkProfiling` flag is a bundled-template change; in `live` mode the menu reads caps from the OAP-published template, so it surfaces after the template is (re)synced to OAP — already pushed to the demo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Satellite series labels, K8S_SERVICE network profiling, and async/pprof create-dialog fixes [skywalking-horizon-ui]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng merged PR #86:
URL: https://github.com/apache/skywalking-horizon-ui/pull/86
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org