You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by er...@apache.org on 2019/10/03 15:27:19 UTC

[commons-numbers] branch master updated (9ad130f -> 595b12a)

This is an automated email from the ASF dual-hosted git repository.

erans pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/commons-numbers.git.


    from 9ad130f  Unit tests.
     new 37e221a  Unit tests.
     new 595b12a  Use consistent spelling for identifiers (except "camel-case").

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .../commons/numbers/complex/ComplexTest.java       | 47 +++++++++++++++-------
 1 file changed, 32 insertions(+), 15 deletions(-)


[commons-numbers] 02/02: Use consistent spelling for identifiers (except "camel-case").

Posted by er...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

erans pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-numbers.git

commit 595b12a8aba51435093a5acca336339d239596f4
Author: Gilles Sadowski <gi...@harfang.homelinux.org>
AuthorDate: Thu Oct 3 17:00:43 2019 +0200

    Use consistent spelling for identifiers (except "camel-case").
---
 .../commons/numbers/complex/ComplexTest.java       | 30 +++++++++++-----------
 1 file changed, 15 insertions(+), 15 deletions(-)

diff --git a/commons-numbers-complex/src/test/java/org/apache/commons/numbers/complex/ComplexTest.java b/commons-numbers-complex/src/test/java/org/apache/commons/numbers/complex/ComplexTest.java
index c554313..e8128dd 100644
--- a/commons-numbers-complex/src/test/java/org/apache/commons/numbers/complex/ComplexTest.java
+++ b/commons-numbers-complex/src/test/java/org/apache/commons/numbers/complex/ComplexTest.java
@@ -35,17 +35,17 @@ public class ComplexTest {
     private static final Complex oneNegInf = Complex.ofCartesian(1, neginf);
     private static final Complex infOne = Complex.ofCartesian(inf, 1);
     private static final Complex infZero = Complex.ofCartesian(inf, 0);
-    private static final Complex infNaN = Complex.ofCartesian(inf, nan);
+    private static final Complex infNan = Complex.ofCartesian(inf, nan);
     private static final Complex infNegInf = Complex.ofCartesian(inf, neginf);
     private static final Complex infInf = Complex.ofCartesian(inf, inf);
     private static final Complex negInfInf = Complex.ofCartesian(neginf, inf);
     private static final Complex negInfZero = Complex.ofCartesian(neginf, 0);
     private static final Complex negInfOne = Complex.ofCartesian(neginf, 1);
-    private static final Complex negInfNaN = Complex.ofCartesian(neginf, nan);
+    private static final Complex negInfNan = Complex.ofCartesian(neginf, nan);
     private static final Complex negInfNegInf = Complex.ofCartesian(neginf, neginf);
-    private static final Complex oneNaN = Complex.ofCartesian(1, nan);
+    private static final Complex oneNan = Complex.ofCartesian(1, nan);
     private static final Complex zeroInf = Complex.ofCartesian(0, inf);
-    private static final Complex zeroNaN = Complex.ofCartesian(0, nan);
+    private static final Complex zeroNan = Complex.ofCartesian(0, nan);
     private static final Complex nanInf = Complex.ofCartesian(nan, inf);
     private static final Complex nanNegInf = Complex.ofCartesian(nan, neginf);
     private static final Complex nanZero = Complex.ofCartesian(nan, 0);
@@ -202,12 +202,12 @@ public class ComplexTest {
     }
 
     @Test
-    public void testDivideNaNInf() {
+    public void testDivideNanInf() {
        Complex z = oneInf.divide(Complex.ONE);
        Assertions.assertTrue(Double.isNaN(z.getReal()));
        Assertions.assertEquals(inf, z.getImaginary(), 0);
 
-       z = negInfNegInf.divide(oneNaN);
+       z = negInfNegInf.divide(oneNan);
        Assertions.assertTrue(Double.isNaN(z.getReal()));
        Assertions.assertTrue(Double.isNaN(z.getImaginary()));
 
@@ -484,7 +484,7 @@ public class ComplexTest {
     }
 
     @Test
-    public void testFloatingPointEqualsWithRelativeToleranceNaN() {
+    public void testFloatingPointEqualsWithRelativeToleranceNan() {
         final Complex x = Complex.ofCartesian(0, Double.NaN);
         final Complex y = Complex.ofCartesian(Double.NaN, 0);
         Assertions.assertFalse(Complex.equalsWithRelativeTolerance(x, Complex.ZERO, 0.1));
@@ -520,10 +520,10 @@ public class ComplexTest {
         Assertions.assertNotEquals(x.hashCode(), y.hashCode());
         y = Complex.ofCartesian(0.0 + Double.MIN_VALUE, 0.0);
         Assertions.assertNotEquals(x.hashCode(), y.hashCode());
-        Complex realNaN = Complex.ofCartesian(Double.NaN, 0.0);
-        Complex imaginaryNaN = Complex.ofCartesian(0.0, Double.NaN);
-        Assertions.assertEquals(realNaN.hashCode(), imaginaryNaN.hashCode());
-        Assertions.assertEquals(imaginaryNaN.hashCode(), NAN.hashCode());
+        Complex realNan = Complex.ofCartesian(Double.NaN, 0.0);
+        Complex imaginaryNan = Complex.ofCartesian(0.0, Double.NaN);
+        Assertions.assertEquals(realNan.hashCode(), imaginaryNan.hashCode());
+        Assertions.assertEquals(imaginaryNan.hashCode(), NAN.hashCode());
 
         // MATH-1118
         // "equals" and "hashCode" must be compatible: if two objects have
@@ -579,7 +579,7 @@ public class ComplexTest {
     }
 
     @Test
-    public void testScalarPowNaNBase() {
+    public void testScalarPowNanBase() {
         Complex x = NAN;
         double yDouble = 5.0;
         Complex yComplex = Complex.ofReal(yDouble);
@@ -604,7 +604,7 @@ public class ComplexTest {
     }
 
     @Test
-    public void testScalarPowNaNExponent() {
+    public void testScalarPowNanExponent() {
         Complex x = Complex.ofCartesian(3, 4);
         double yDouble = Double.NaN;
         Complex yComplex = Complex.ofReal(yDouble);
@@ -803,7 +803,7 @@ public class ComplexTest {
     }
 
     @Test
-    public void testNthRootNaN() {
+    public void testNthRootNan() {
         final int n = 3;
         final Complex z = Complex.ofReal(Double.NaN);
         final List<Complex> r = z.nthRoot(n);
@@ -873,7 +873,7 @@ public class ComplexTest {
     @Test
     public void testGetArgumentNaN() {
         Assertions.assertTrue(Double.isNaN(nanZero.getArgument()));
-        Assertions.assertTrue(Double.isNaN(zeroNaN.getArgument()));
+        Assertions.assertTrue(Double.isNaN(zeroNan.getArgument()));
         Assertions.assertTrue(Double.isNaN(NAN.getArgument()));
     }
 


[commons-numbers] 01/02: Unit tests.

Posted by er...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

erans pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-numbers.git

commit 37e221a79e2a78a99130ae0602c295c45d50ca10
Author: Gilles Sadowski <gi...@harfang.homelinux.org>
AuthorDate: Thu Oct 3 16:20:46 2019 +0200

    Unit tests.
---
 .../org/apache/commons/numbers/complex/ComplexTest.java | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/commons-numbers-complex/src/test/java/org/apache/commons/numbers/complex/ComplexTest.java b/commons-numbers-complex/src/test/java/org/apache/commons/numbers/complex/ComplexTest.java
index be763f9..c554313 100644
--- a/commons-numbers-complex/src/test/java/org/apache/commons/numbers/complex/ComplexTest.java
+++ b/commons-numbers-complex/src/test/java/org/apache/commons/numbers/complex/ComplexTest.java
@@ -587,6 +587,23 @@ public class ComplexTest {
     }
 
     @Test
+    public void testScalarPowZeroBaseZeroExponent() {
+        Complex x = Complex.ZERO;
+        double yDouble = 0;
+        Assertions.assertEquals(NAN, x.pow(yDouble));
+        Complex yComplex = Complex.ofReal(yDouble);
+        Assertions.assertEquals(NAN, x.pow(yComplex));
+    }
+    @Test
+    public void testScalarPowZeroBasePositiveExponent() {
+        Complex x = Complex.ZERO;
+        double yDouble = Double.MIN_VALUE;
+        Assertions.assertEquals(Complex.ZERO, x.pow(yDouble));
+        Complex yComplex = Complex.ofReal(yDouble);
+        Assertions.assertEquals(Complex.ZERO, x.pow(yComplex));
+    }
+
+    @Test
     public void testScalarPowNaNExponent() {
         Complex x = Complex.ofCartesian(3, 4);
         double yDouble = Double.NaN;