You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/05/29 23:54:54 UTC

[GitHub] [helix] xyuanlu opened a new issue #1042: Validate instance topology configuration before let it comes online

xyuanlu opened a new issue #1042:
URL: https://github.com/apache/helix/issues/1042


   Helix does not check if an instance's topology config is defined correctly when the instance is added or joins cluster. This will cause Helix to fail the rebalance. We could add the sanity check when 
       1. Instance is added to the cluster,
       2. Instance joins cluster,
       3. User update InstanceConfig.
       4. Controller prepares the topology structure for rebalance   <-- Currently we only check here
       
   Since we already have sanity check logic in controller/rebalancer/topology/Topology.java and controller/rebalancer/waged/model/AssignableNode.java, it's better to extract the logic into an util function first and use the same logic to do sanity check in multiple places. 
   
   
   
   Reference: https://cwiki.apache.org/confluence/display/HELIX/Helix+Topology-aware+Rebalance+Strategy#HelixTopology-awareRebalanceStrategy-TopologyInformation
   
    


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org

[GitHub] [helix] xyuanlu closed issue #1042: Validate instance topology configuration before let it comes online

Posted by GitBox <gi...@apache.org>.
xyuanlu closed issue #1042:
URL: https://github.com/apache/helix/issues/1042


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org