[GitHub] [incubator-pinot] mayankshriv commented on pull request #5316: Initial implementation for support Theta Sketches (WIP).

[GitBox <gi...@apache.org>]

mayankshriv commented on pull request #5316:
URL: https://github.com/apache/incubator-pinot/pull/5316#issuecomment-625410686


   > > > can we simplify the way we define the expression?
   > > > for e.g.
   > > > `select distinctCountThetaSketch(tsCol, "dim1='foo', dim2='bar', "dim1 = 'foo and dim2='bar')`
   > > > to
   > > > `select distinctCountThetaSketch(tsCol, "dim1='foo'", "dim2='bar'", "1 AND 2")`
   > > 
   > > 
   > > Yes agree, this is a good idea, specially in case when predicates are long strings. Will address that in following PRs.
   > 
   > Is it possible to do `select distinctCountThetaSketch(tsCol, ("dim1=foo" AND "dim2=bar"))` and parse it to get what we want? Why is that a problem?
   
   One issue with auto deriving is that we can only  derive the lowest level predicates, and not a combination if that was already applied. However, I am unsure we can get to that, so I am already trying to see if I can get rid of p1/p2/p3... in this PR (will update).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org