You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/06/18 21:10:47 UTC
[GitHub] [airflow] freget opened a new pull request #16522: Tree View UI for larger DAGs & more consistent spacing in Tree View
freget opened a new pull request #16522:
URL: https://github.com/apache/airflow/pull/16522
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
closes: #16238
Currently, the space available for the tree and operator names in the tree view is calculated by substracting a quite a few things from the screen width. This does not really make sense. It would be better to calculate the required width of the tree and add some more for operator names.
This PR makes a suggestion accordingly.
Note: It might be even better to calculate the required width for operator names dynamically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #16522: Tree View UI for larger DAGs & more consistent spacing in Tree View
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #16522:
URL: https://github.com/apache/airflow/pull/16522#issuecomment-865124464
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] freget commented on a change in pull request #16522: Tree View UI for larger DAGs & more consistent spacing in Tree View
Posted by GitBox <gi...@apache.org>.
freget commented on a change in pull request #16522:
URL: https://github.com/apache/airflow/pull/16522#discussion_r654968844
##########
File path: airflow/www/static/js/tree.js
##########
@@ -73,7 +73,7 @@ document.addEventListener('DOMContentLoaded', () => {
treeDepth += 1;
const innerWidth = window.innerWidth > 1200 ? 1200 : window.innerWidth;
Review comment:
@bbovenzi Thanks, I should have checked that upfront.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ryanahamilton merged pull request #16522: Tree View UI for larger DAGs & more consistent spacing in Tree View
Posted by GitBox <gi...@apache.org>.
ryanahamilton merged pull request #16522:
URL: https://github.com/apache/airflow/pull/16522
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] freget commented on pull request #16522: Tree View UI for larger DAGs & more consistent spacing in Tree View
Posted by GitBox <gi...@apache.org>.
freget commented on pull request #16522:
URL: https://github.com/apache/airflow/pull/16522#issuecomment-864575873
@bbovenzi Maybe you can have a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ryanahamilton merged pull request #16522: Tree View UI for larger DAGs & more consistent spacing in Tree View
Posted by GitBox <gi...@apache.org>.
ryanahamilton merged pull request #16522:
URL: https://github.com/apache/airflow/pull/16522
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #16522: Tree View UI for larger DAGs & more consistent spacing in Tree View
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #16522:
URL: https://github.com/apache/airflow/pull/16522#issuecomment-865124464
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi commented on a change in pull request #16522: Tree View UI for larger DAGs & more consistent spacing in Tree View
Posted by GitBox <gi...@apache.org>.
bbovenzi commented on a change in pull request #16522:
URL: https://github.com/apache/airflow/pull/16522#discussion_r654966559
##########
File path: airflow/www/static/js/tree.js
##########
@@ -73,7 +73,7 @@ document.addEventListener('DOMContentLoaded', () => {
treeDepth += 1;
const innerWidth = window.innerWidth > 1200 ? 1200 : window.innerWidth;
Review comment:
```suggestion
```
This line is no longer necessary then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi commented on a change in pull request #16522: Tree View UI for larger DAGs & more consistent spacing in Tree View
Posted by GitBox <gi...@apache.org>.
bbovenzi commented on a change in pull request #16522:
URL: https://github.com/apache/airflow/pull/16522#discussion_r654966559
##########
File path: airflow/www/static/js/tree.js
##########
@@ -73,7 +73,7 @@ document.addEventListener('DOMContentLoaded', () => {
treeDepth += 1;
const innerWidth = window.innerWidth > 1200 ? 1200 : window.innerWidth;
Review comment:
```suggestion
```
This line is no longer necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org