You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/08/28 15:52:34 UTC

[GitHub] [pulsar-client-go] merlimat commented on a change in pull request #604: User-defined metric cardinality

merlimat commented on a change in pull request #604:
URL: https://github.com/apache/pulsar-client-go/pull/604#discussion_r697885043



##########
File path: pulsar/internal/metrics.go
##########
@@ -21,9 +21,8 @@ import (
 	"github.com/prometheus/client_golang/prometheus"
 )
 
-var topicLabelNames = []string{"pulsar_tenant", "pulsar_namespace", "topic"}
-
 type Metrics struct {
+	metricsLevel      int

Review comment:
       Would it make sense to define a 2nd enum for internal use instead of ints?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org