You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2019/10/02 10:48:32 UTC
[GitHub] [zookeeper] eolivelli commented on a change in pull request #136:
[ZOOKEEPER-1416] Persistent Recursive Watch
eolivelli commented on a change in pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch
URL: https://github.com/apache/zookeeper/pull/136#discussion_r330484335
##########
File path: src/java/main/org/apache/zookeeper/server/WatchManager.java
##########
@@ -40,50 +40,110 @@
class WatchManager {
private static final Logger LOG = LoggerFactory.getLogger(WatchManager.class);
- private final Map<String, Set<Watcher>> watchTable =
- new HashMap<String, Set<Watcher>>();
+ enum Type {
+ STANDARD() {
Review comment:
nit: you can have two field in the enum without creating subclasses
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services