[GitHub] cbickel commented on issue #3342: #3168 Rate limit requests to download CLI, Docker and iOS SDKs

[GitBox <gi...@apache.org>]

cbickel commented on issue #3342:  #3168 Rate limit requests to download CLI, Docker and iOS SDKs
URL: https://github.com/apache/incubator-openwhisk/pull/3342#issuecomment-374511609
 
 
   @mptap 
   Thanks a lot for your contribution. I like the idea of limiting the download of some attributes, to prevent dos attacks.
   
   But I also have two concerns: 
   - If this nginx is not the front-door, (e.g. Openwhisk is only one of many offerings of one company), than the rate limit would apply on the frontdoor in front of this nginx, right? Then users may experience issues in downloading the CLI, because others do this as well.
   - If a company or university wants to introduce OpenWhisk, the students/employees may try to download the CLI at once. In most cases, this is one IP as well. Then the first impression for some of them may be a bad experience.
   
   A agree, that these two examples are only edge-cases. But I think as this is the first experience of a new user, we have to think about it.
   
   One solution to work around this (especially the first problem) may be to make the limits configurable (and add the ability to disable them).
   
   Do you think it makes sense to write a short test, to check that the limits are really applied? (Also to avoid, that they are not applied at some day anymore, because of some configuration changes by other contributors)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services