You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/10/25 14:37:16 UTC

[GitHub] [beam] damondouglas commented on a change in pull request #15787: [BEAM-13062][Playground] Update errors in Protobuf

damondouglas commented on a change in pull request #15787:
URL: https://github.com/apache/beam/pull/15787#discussion_r735667223



##########
File path: playground/backend/README.md
##########
@@ -48,9 +48,9 @@ should be generated firstly using the `playground/proto/playground.proto` file.
 Run the following command from `/playground` directory:
 
 ```
-protoc --go_out=backend/pkg/api --go_opt=paths=source_relative \
---go-grpc_out=backend/pkg/api --go-grpc_opt=paths=source_relative --proto_path=playground/v1 \
-playground.proto
+protoc --go_out=backend/internal/api/v1 --go_opt=paths=source_relative \

Review comment:
       One can just use the buf utility that is recommend for installation in [playground/README.md](https://github.com/akvelon/beam/blob/BEAM-13062-add-statuses/playground/README.md).  Or one could just at the root of this project run:
   ```
   ./gradlew playground:generateProto
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org