You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@jackrabbit.apache.org by GitBox <gi...@apache.org> on 2021/04/29 06:33:16 UTC

[GitHub] [jackrabbit-filevault] stoerr commented on a change in pull request #136: JCRVLT-517 fix package cache init in OSGi containers

stoerr commented on a change in pull request #136:
URL: https://github.com/apache/jackrabbit-filevault/pull/136#discussion_r622768174



##########
File path: vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/registry/impl/FSPackageRegistry.java
##########
@@ -185,6 +182,7 @@ public void activate(BundleContext context, Config config) {
         log.info("Jackrabbit Filevault FS Package Registry initialized with home location {}", this.homeDir.getPath());
         this.scope = InstallationScope.valueOf(config.scope());
         this.securityConfig = new AbstractPackageRegistry.SecurityConfig(config.authIdsForHookExecution(), config.authIdsForRootInstallation());
+        loadPackageCache();

Review comment:
       I think doing file system accesses within the OSGI activation is dangerous - please see my comment https://github.com/apache/jackrabbit-filevault/pull/136#issuecomment-828974792 .




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org