[GitHub] [flink] WeiZhong94 commented on a change in pull request #10017: [FLINK-14019][python] add support for managing environment and dependencies of Python UDF in Flink Python API

[GitBox <gi...@apache.org>]

WeiZhong94 commented on a change in pull request #10017: [FLINK-14019][python] add support for managing environment and dependencies of Python UDF in Flink Python API
URL: https://github.com/apache/flink/pull/10017#discussion_r342995784
 
 

 ##########
 File path: flink-python/src/main/java/org/apache/flink/streaming/api/operators/python/AbstractPythonFunctionOperator.java
 ##########
 @@ -75,6 +80,7 @@
 	 * A timer that finishes the current bundle after a fixed amount of time.
 	 */
 	private transient ScheduledFuture<?> checkFinishBundleTimer;
+	protected PythonEnvironmentManager environmentManager;
 
 Review comment:
   I agree that it is unnecessary to add it here. 
   But the creation of environment manager relies on the information provided by flink operators, such as pythonEnv, temp directory path, dependency manager, and these data is no use for Runner except creating environment manager. Maybe we can initialize the environment manager in the base operator and pass to Runner immediately in open method? 
   If move the creation to Runner it will introduce additional concrete class dependency (ProcessEnvironmentManager and DockerEnvironmentManager in the future) of python environment managers.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services