You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by smarthi <gi...@git.apache.org> on 2016/01/27 05:43:30 UTC
[GitHub] flink pull request: Flink-3196: InputStream should be closed in En...
GitHub user smarthi opened a pull request:
https://github.com/apache/flink/pull/1552
Flink-3196: InputStream should be closed in EnvironmentInformation#ge…
…tRevisionInformation()
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/smarthi/flink Flink-3196
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1552.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1552
----
commit 26419e2d95b735a1568385cc75c0d107f42ee909
Author: smarthi <sm...@apache.org>
Date: 2016-01-27T04:42:33Z
Flink-3196: InputStream should be closed in EnvironmentInformation#getRevisionInformation()
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [Flink-3196] InputStream should be closed in E...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1552#discussion_r50959035
--- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/util/EnvironmentInformation.java ---
@@ -70,10 +70,9 @@ public static RevisionInformation getRevisionInformation() {
revision = propRevision != null ? propRevision : UNKNOWN;
commitDate = propCommitDate != null ? propCommitDate : UNKNOWN;
}
- }
- catch (Throwable t) {
+ } catch (IOException ex) {
--- End diff --
I would like to keep catching `Throwable`, or at least `Exception` here, as this is a method that should not error out in any case.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [Flink-3196] InputStream should be closed in E...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1552#issuecomment-176183398
Looks good, thanks, merging this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [Flink-3196] InputStream should be closed in E...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1552
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---