You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Laszlo Gaal (Code Review)" <ge...@cloudera.org> on 2020/04/28 12:44:47 UTC
[native-toolchain-CR] Clone the Kudu repo using HTTPS by default
Laszlo Gaal has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15832
Change subject: Clone the Kudu repo using HTTPS by default
......................................................................
Clone the Kudu repo using HTTPS by default
Since GitHub started enforcing TLSv1.2 for HTTPS connections, the Kudu
repo on Github was cloned via SSH. Unfortunately the default SSH access
used for this depended on obscure default credentials, which failed
to work in some of the cases.
WIth Impala 4.x dropping support for older OS platforms, now all the
supported OSs are capable of TLSv1.2, so it is safe to reset default
access to HTTPS.
Change-Id: I2486b34e7ae62eecb49ab0a602308b9fe898c8d0
---
M source/kudu/build.sh
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/32/15832/1
--
To view, visit http://gerrit.cloudera.org:8080/15832
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2486b34e7ae62eecb49ab0a602308b9fe898c8d0
Gerrit-Change-Number: 15832
Gerrit-PatchSet: 1
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
[native-toolchain-CR] Clone the Kudu repo using HTTPS by default
Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/15832 )
Change subject: Clone the Kudu repo using HTTPS by default
......................................................................
Clone the Kudu repo using HTTPS by default
Since GitHub started enforcing TLSv1.2 for HTTPS connections, the Kudu
repo on Github was cloned via SSH. Unfortunately the default SSH access
used for this depended on obscure default credentials, which failed
to work in some of the cases.
WIth Impala 4.x dropping support for older OS platforms, now all the
supported OSs are capable of TLSv1.2, so it is safe to reset default
access to HTTPS.
Tested by rebuilding the toolchain in a local Docker container; verified
that cloning teh Kudu repo is successful with no user interaction
required.
Change-Id: I2486b34e7ae62eecb49ab0a602308b9fe898c8d0
---
M source/kudu/build.sh
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/32/15832/2
--
To view, visit http://gerrit.cloudera.org:8080/15832
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2486b34e7ae62eecb49ab0a602308b9fe898c8d0
Gerrit-Change-Number: 15832
Gerrit-PatchSet: 2
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
[native-toolchain-CR] Clone the Kudu repo using HTTPS by default
Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/15832 )
Change subject: Clone the Kudu repo using HTTPS by default
......................................................................
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15832/2/source/kudu/build.sh
File source/kudu/build.sh:
http://gerrit.cloudera.org:8080/#/c/15832/2/source/kudu/build.sh@72
PS2, Line 72:
> Please update comment
Done
--
To view, visit http://gerrit.cloudera.org:8080/15832
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2486b34e7ae62eecb49ab0a602308b9fe898c8d0
Gerrit-Change-Number: 15832
Gerrit-PatchSet: 5
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 30 Apr 2020 15:43:58 +0000
Gerrit-HasComments: Yes
[native-toolchain-CR] Clone the Kudu repo using HTTPS by default
Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Hello Thomas Tauber-Marshall, Zoltan Borok-Nagy, Attila Jeges, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15832
to look at the new patch set (#5).
Change subject: Clone the Kudu repo using HTTPS by default
......................................................................
Clone the Kudu repo using HTTPS by default
Since GitHub started enforcing TLSv1.2 for HTTPS connections, the Kudu
repo on Github was cloned via SSH. Unfortunately the default SSH access
used for this depended on obscure default credentials, which failed
to work in some of the cases.
WIth Impala 4.x dropping support for older OS platforms, now all the
supported OSs are capable of TLSv1.2, so it is safe to reset default
access to HTTPS.
Tested by rebuilding the toolchain in a local Docker container; verified
that cloning teh Kudu repo is successful with no user interaction
required.
Change-Id: I2486b34e7ae62eecb49ab0a602308b9fe898c8d0
---
M source/kudu/build.sh
1 file changed, 2 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/32/15832/5
--
To view, visit http://gerrit.cloudera.org:8080/15832
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2486b34e7ae62eecb49ab0a602308b9fe898c8d0
Gerrit-Change-Number: 15832
Gerrit-PatchSet: 5
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[native-toolchain-CR] Clone the Kudu repo using HTTPS by default
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/15832 )
Change subject: Clone the Kudu repo using HTTPS by default
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15832/2/source/kudu/build.sh
File source/kudu/build.sh:
http://gerrit.cloudera.org:8080/#/c/15832/2/source/kudu/build.sh@72
PS2, Line 72: Fetch over SSH because github.com does not allow TLS < V1.2
Please update comment
--
To view, visit http://gerrit.cloudera.org:8080/15832
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2486b34e7ae62eecb49ab0a602308b9fe898c8d0
Gerrit-Change-Number: 15832
Gerrit-PatchSet: 2
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Apr 2020 14:07:26 +0000
Gerrit-HasComments: Yes
[native-toolchain-CR] Clone the Kudu repo using HTTPS by default
Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15832 )
Change subject: Clone the Kudu repo using HTTPS by default
......................................................................
Clone the Kudu repo using HTTPS by default
Since GitHub started enforcing TLSv1.2 for HTTPS connections, the Kudu
repo on Github was cloned via SSH. Unfortunately the default SSH access
used for this depended on obscure default credentials, which failed
to work in some of the cases.
WIth Impala 4.x dropping support for older OS platforms, now all the
supported OSs are capable of TLSv1.2, so it is safe to reset default
access to HTTPS.
Tested by rebuilding the toolchain in a local Docker container; verified
that cloning the Kudu repo is successful with no user interaction
required.
Change-Id: I2486b34e7ae62eecb49ab0a602308b9fe898c8d0
Reviewed-on: http://gerrit.cloudera.org:8080/15832
Reviewed-by: Laszlo Gaal <la...@cloudera.com>
Tested-by: Laszlo Gaal <la...@cloudera.com>
---
M source/kudu/build.sh
1 file changed, 2 insertions(+), 3 deletions(-)
Approvals:
Laszlo Gaal: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/15832
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2486b34e7ae62eecb49ab0a602308b9fe898c8d0
Gerrit-Change-Number: 15832
Gerrit-PatchSet: 7
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[native-toolchain-CR] Clone the Kudu repo using HTTPS by default
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15832 )
Change subject: Clone the Kudu repo using HTTPS by default
......................................................................
Patch Set 2: Code-Review+2
LGTM once you fix Zoltan's comment
--
To view, visit http://gerrit.cloudera.org:8080/15832
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2486b34e7ae62eecb49ab0a602308b9fe898c8d0
Gerrit-Change-Number: 15832
Gerrit-PatchSet: 2
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Apr 2020 16:15:05 +0000
Gerrit-HasComments: No
[native-toolchain-CR] Clone the Kudu repo using HTTPS by default
Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/15832 )
Change subject: Clone the Kudu repo using HTTPS by default
......................................................................
Patch Set 6: Verified+1 Code-Review+2
(1 comment)
Carry +2 from Tim
Verified by a full build for all platforms with the rebased Kudu git hash.
http://gerrit.cloudera.org:8080/#/c/15832/5//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/15832/5//COMMIT_MSG@18
PS5, Line 18: the
> nit: typo
Done
--
To view, visit http://gerrit.cloudera.org:8080/15832
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2486b34e7ae62eecb49ab0a602308b9fe898c8d0
Gerrit-Change-Number: 15832
Gerrit-PatchSet: 6
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 30 Apr 2020 15:45:29 +0000
Gerrit-HasComments: Yes
[native-toolchain-CR] Clone the Kudu repo using HTTPS by default
Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Hello Thomas Tauber-Marshall, Zoltan Borok-Nagy, Attila Jeges, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15832
to look at the new patch set (#6).
Change subject: Clone the Kudu repo using HTTPS by default
......................................................................
Clone the Kudu repo using HTTPS by default
Since GitHub started enforcing TLSv1.2 for HTTPS connections, the Kudu
repo on Github was cloned via SSH. Unfortunately the default SSH access
used for this depended on obscure default credentials, which failed
to work in some of the cases.
WIth Impala 4.x dropping support for older OS platforms, now all the
supported OSs are capable of TLSv1.2, so it is safe to reset default
access to HTTPS.
Tested by rebuilding the toolchain in a local Docker container; verified
that cloning the Kudu repo is successful with no user interaction
required.
Change-Id: I2486b34e7ae62eecb49ab0a602308b9fe898c8d0
---
M source/kudu/build.sh
1 file changed, 2 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/32/15832/6
--
To view, visit http://gerrit.cloudera.org:8080/15832
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2486b34e7ae62eecb49ab0a602308b9fe898c8d0
Gerrit-Change-Number: 15832
Gerrit-PatchSet: 6
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[native-toolchain-CR] Clone the Kudu repo using HTTPS by default
Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/15832 )
Change subject: Clone the Kudu repo using HTTPS by default
......................................................................
Patch Set 6:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15832/5//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/15832/5//COMMIT_MSG@18
PS5, Line 18: the
nit: typo
--
To view, visit http://gerrit.cloudera.org:8080/15832
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2486b34e7ae62eecb49ab0a602308b9fe898c8d0
Gerrit-Change-Number: 15832
Gerrit-PatchSet: 6
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 30 Apr 2020 15:44:36 +0000
Gerrit-HasComments: Yes