[jira] [Commented] (SINGA-140) A bug in CollectAll() function when layers are unrolled in neuralnet

["Raunaq Abhyankar (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SINGA-140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15213113#comment-15213113 ] 

Raunaq Abhyankar commented on SINGA-140:
----------------------------------------

Hi! 
I would like to take up this bug.. Any advice you would like to give? 
And how do i check whether the changes have worked or not?
Thanks! :)

> A bug in CollectAll() function when layers are unrolled in neuralnet
> --------------------------------------------------------------------
>
>                 Key: SINGA-140
>                 URL: https://issues.apache.org/jira/browse/SINGA-140
>             Project: Singa
>          Issue Type: Bug
>            Reporter: Zheng Kaiping
>
> In SINGA_HOME/src/work.cc, in “int Worker::CollectAll(int step, NeuralNet* net){}” function, the layers which are unrolled (except for the first one) should not collect parameters, due to parameter sharing.
> Previous:
> if (layer->partition_id() == id_)
> Possible changes:
> if (layer->partition_id() == id_ && layer->unroll_index() == 0)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)