You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "6Glory9 (via GitHub)" <gi...@apache.org> on 2024/03/07 08:09:31 UTC

[I] all channels of the EventLoop delay time [dubbo]

6Glory9 opened a new issue, #13853:
URL: https://github.com/apache/dubbo/issues/13853

   ### Pre-check
   
   - [X] I am sure that all the content I provide is in English.
   
   
   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/dubbo/issues?q=is%3Aissue) and found no similar issues.
   
   
   ### Apache Dubbo Component
   
   Java SDK (apache/dubbo)
   
   ### Dubbo Version
   
   dubbo 3.2.12
   
   ### Steps to reproduce this issue
   
   `org.apache.dubbo.remoting.transport.netty4.NettyConnectionClient.ConnectionListener#operationComplete
   
    final EventLoop loop = future.channel().eventLoop();
               loop.schedule(
                       () -> {
                           try {
                               connectionClient.doConnect();
                           } catch (RemotingException e) {
                               LOGGER.error(
                                       TRANSPORT_FAILED_RECONNECT,
                                       "",
                                       "",
                                       "Failed to connect to server: " + getConnectAddress());
                           }
                       },
                       1L,
                       TimeUnit.SECONDS);
   
   `
   connectionClient Always fails to connect, default connection wait time is 3 seconds. This will occupy the  EventLoop CPU from time to time, and indirectly affect the communication of other registered EventLoop channels. Sometimes there may be a request timeout.
   1. The server receives the request with a delay.Timely
   2. server execution is short, client still sometimes timeout.
   
   
   ### What you expected to happen
   
   1. Simply handle the connection and wait only for a shorter period of time. For example, 500ms, this way, has been provided. The dead loop body occupies the EventLoop for a long time.
   
   2. It is recommended to add a user thread instead of the EventLoop
   
   ### Anything else
   
   _No response_
   
   ### Are you willing to submit a pull request to fix on your own?
   
   - [X] Yes I am willing to submit a pull request on my own!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Re: [I] [Bug] all channels of the EventLoop delay time [dubbo]

Posted by "AlbumenJ (via GitHub)" <gi...@apache.org>.
AlbumenJ commented on issue #13853:
URL: https://github.com/apache/dubbo/issues/13853#issuecomment-2151344565

   > > > I'm willing to do it ,pls assign to me.
   > > 
   > > 
   > > We have a [PR](https://github.com/apache/dubbo/pull/13904) related with this issue. For further improvement, we need to consider use async connection future instead of sync. But this may cause a lot of changes in Dubbo. And would you like to work for it?我们有一个与此问题相关的 PR。为了进一步改进,我们需要考虑使用异步连接 future 而不是同步。但这可能会导致Dubbo发生很多变化。你愿意为此工作吗?
   > 
   > Should we close this issue and create a new feature to describe this functionality?
   
   Here you go


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Re: [I] all channels of the EventLoop delay time [dubbo]

Posted by "AlbumenJ (via GitHub)" <gi...@apache.org>.
AlbumenJ commented on issue #13853:
URL: https://github.com/apache/dubbo/issues/13853#issuecomment-1984917904

   @icodening PTAL


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Re: [I] [Bug] all channels of the EventLoop delay time [dubbo]

Posted by "vedansh-5 (via GitHub)" <gi...@apache.org>.
vedansh-5 commented on issue #13853:
URL: https://github.com/apache/dubbo/issues/13853#issuecomment-2661416608

   Hey, I would like to contribute, can you assign this issue to me?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Re: [I] [Bug] all channels of the EventLoop delay time [dubbo]

Posted by "Anon2Tokyo (via GitHub)" <gi...@apache.org>.
Anon2Tokyo commented on issue #13853:
URL: https://github.com/apache/dubbo/issues/13853#issuecomment-5207189190

   @AlbumenJ This appears to have been fixed by #13904 (`f03823eec`, "Use ExecutorService instead of event loop for Netty connection").
   
   The reconnect scheduling path no longer uses `future.channel().eventLoop().schedule(...)`; it now schedules reconnects through `connectivityExecutor.schedule(...)` in `AbstractNettyConnectionClient`.
   
   I think this issue can be closed as fixed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Re: [I] all channels of the EventLoop delay time [dubbo]

Posted by "icodening (via GitHub)" <gi...@apache.org>.
icodening commented on issue #13853:
URL: https://github.com/apache/dubbo/issues/13853#issuecomment-1984927586

   Same as #13041.  Welcome to submit PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Re: [I] [Bug] all channels of the EventLoop delay time [dubbo]

Posted by "simhadri-s (via GitHub)" <gi...@apache.org>.
simhadri-s commented on issue #13853:
URL: https://github.com/apache/dubbo/issues/13853#issuecomment-2666043287

   Hello sir. I would like to work on this issue. Can you assign this to me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Re: [I] [Bug] all channels of the EventLoop delay time [dubbo]

Posted by "LeonxLJX (via GitHub)" <gi...@apache.org>.
LeonxLJX commented on issue #13853:
URL: https://github.com/apache/dubbo/issues/13853#issuecomment-5492473186

   I'd like to take this one (`[Bug] all channels of the EventLoop  delay time`). I'll look into the root cause and follow up with a PR. (claiming via @LeonxLJX)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Re: [I] [Bug] all channels of the EventLoop delay time [dubbo]

Posted by "AlbumenJ (via GitHub)" <gi...@apache.org>.
AlbumenJ commented on issue #13853:
URL: https://github.com/apache/dubbo/issues/13853#issuecomment-1996628626

   > I'm willing to do it ,pls assign to me.
   
   We have a [PR](https://github.com/apache/dubbo/pull/13904) related with this issue. For further improvement, we need to consider use async connection future instead of sync. But this may cause a lot of changes in Dubbo. And would you like to work for it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Re: [I] [Bug] all channels of the EventLoop delay time [dubbo]

Posted by "LeonxLJX (via GitHub)" <gi...@apache.org>.
LeonxLJX commented on issue #13853:
URL: https://github.com/apache/dubbo/issues/13853#issuecomment-5493432047

   I'd like to take this one (`[Bug] all channels of the EventLoop  delay time`). I'll dig into the root cause and follow up with a PR shortly. (claiming via @LeonxLJX)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Re: [I] [Bug] all channels of the EventLoop delay time [dubbo]

Posted by "Anon2Tokyo (via GitHub)" <gi...@apache.org>.
Anon2Tokyo commented on issue #13853:
URL: https://github.com/apache/dubbo/issues/13853#issuecomment-5206984339

   Hi, I noticed this issue has been assigned for a while but there does not seem to have been recent progress.
   
   If the current assignee is no longer working on it, I'd be happy to take it over and submit a PR.
   
   Could a maintainer confirm whether it would be okay for me to work on this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Re: [I] [Bug] all channels of the EventLoop delay time [dubbo]

Posted by "GerardGao (via GitHub)" <gi...@apache.org>.
GerardGao commented on issue #13853:
URL: https://github.com/apache/dubbo/issues/13853#issuecomment-5406830355

   Hi, I've submitted PR #16436 to address this issue. The blocking `doConnect()` was still running inline on the shared framework connectivity scheduler (a residual of the original EventLoop issue after the scheduler refactor), which can starve reconnect tasks of other clients. The fix delegates the blocking connect to the per-client executor. The added test verifies the reconnect runs on the client executor thread and fails on the previous implementation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Re: [I] [Bug] all channels of the EventLoop delay time [dubbo]

Posted by "wcy666103 (via GitHub)" <gi...@apache.org>.
wcy666103 commented on issue #13853:
URL: https://github.com/apache/dubbo/issues/13853#issuecomment-2148976379

   > > I'm willing to do it ,pls assign to me.
   > 
   > We have a [PR](https://github.com/apache/dubbo/pull/13904) related with this issue. For further improvement, we need to consider use async connection future instead of sync. But this may cause a lot of changes in Dubbo. And would you like to work for it?我们有一个与此问题相关的 PR。为了进一步改进,我们需要考虑使用异步连接 future 而不是同步。但这可能会导致Dubbo发生很多变化。你愿意为此工作吗?
   
   Should we close this issue and create a new feature to describe this functionality?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Re: [I] [Bug] all channels of the EventLoop delay time [dubbo]

Posted by "tritone-l (via GitHub)" <gi...@apache.org>.
tritone-l commented on issue #13853:
URL: https://github.com/apache/dubbo/issues/13853#issuecomment-1994263604

   I'm willing to do it ,pls assign to me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Re: [I] [Bug] all channels of the EventLoop delay time [dubbo]

Posted by "ShyamSathish005 (via GitHub)" <gi...@apache.org>.
ShyamSathish005 commented on issue #13853:
URL: https://github.com/apache/dubbo/issues/13853#issuecomment-2547439104

   Instead of scheduling reconnection attempts directly on the` EventLoop`, a separate user-managed thread pool can be used. This can prevent the` EventLoop` from being blocked by reconnection logic, reducing its impact on communication and performance.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Re: [I] [Bug] all channels of the EventLoop delay time [dubbo]

Posted by "LeonxLJX (via GitHub)" <gi...@apache.org>.
LeonxLJX commented on issue #13853:
URL: https://github.com/apache/dubbo/issues/13853#issuecomment-5493409728

   I'd like to take this one (`[Bug] all channels of the EventLoop  delay time`). I'll look into the root cause and follow up with a PR. (claiming via @LeonxLJX)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Re: [I] [Bug] all channels of the EventLoop delay time [dubbo]

Posted by "Anon2Tokyo (via GitHub)" <gi...@apache.org>.
Anon2Tokyo commented on issue #13853:
URL: https://github.com/apache/dubbo/issues/13853#issuecomment-5206966199

   is this still available?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org