You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@grails.apache.org by "borinquenkid (via GitHub)" <gi...@apache.org> on 2026/10/11 01:28:01 UTC

[PR] refactor: convert grails-logging, grails-quartz, grails-startup-progress and grails-datasource to Groovy [grails-core]

borinquenkid opened a new pull request, #16590:
URL: https://github.com/apache/grails-core/pull/16590

   ## What
   
   Converts the remaining Java sources of `grails-logging`, `grails-quartz`, `grails-startup-progress`, `grails-datasource` to Groovy: 21 `.java` files removed, 27 `.groovy` files added (30 files changed, 2224 insertions(+), 1517 deletions(-)).
   
   ## Why
   
   The maintainers asked on #16351 for the Java-to-Groovy migration to land one Gradle project at a time as a stack of PRs, bottom-up in dependency order. #16572 did `grails-data-hibernate7`; this PR is 12 of 30 in the next stack (base: `refactor/java-to-groovy-grails-encoder`). The end state of every file is taken from the `9.0.x-java-to-groovy` branch, which already carries the regression fixes found by CI.
   
   Commits:
   - 11d6abe39e refactor: convert grails-datasource to Groovy
   - 235a945774 refactor: convert grails-startup-progress to Groovy
   - 93a46b73cd refactor: convert grails-quartz to Groovy
   - 7b9ed6f775 refactor: convert grails-logging to Groovy
   
   ## Changed outside the converted sources
   
   - nothing
   
   ## Java-facing API sweep
   
   Every deleted `.java` was compared with its Groovy twin via `javap -v -protected` (class declaration, public/protected fields, constructors, methods incl. modifiers/throws/generics, interface default methods, nested class modifiers, and the annotations callers see). Result:
   
   - `grails-logging`: 1 deleted .java, 0 differences requiring action
   - `grails-quartz`: 8 deleted .java, 0 differences requiring action
   - `grails-startup-progress`: 11 deleted .java, 0 differences requiring action
   - `grails-datasource`: 1 deleted .java, 0 differences requiring action
   
   See also the notes below. Remaining informational entries (widened visibility, e.g. Groovy property accessors): 3.
   
   ## Verification
   
   - `classes` and `testClasses` (plus `ast`/`cli`/`testFixtures` source sets where present) of the converted project(s) and of their direct dependents compile: ['grails-rest-transforms', 'grails-services', 'grails-spring-security-acl', 'grails-test-suite-persistence', 'grails-test-suite-uber']
   - No test suites were run locally (the umbrella branch was verified; CI runs them). `codeStyle`, `rat` and a whole-repo `build -PskipTests` are run once on the tip of the stack.
   
   ## Notes
   
   - Informational sweep entries that are not regressions: Groovy enums gain `MIN_VALUE`/`MAX_VALUE`/`next()`/`previous()`, property accessors appear for formerly package-private members, nested static classes with implicit constructors become public (they were `protected`), and generic type parameters that Groovy erases in constructors/methods (descriptors identical).
   - Groovy gotchas that applied (see #16351): `static final` without `public` creates a property; `==` calls `equals()`; Closure/SAM coercions; `@CompileStatic` with nested classes. All CI regression fixes found on the umbrella branch are included in the end state.
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] refactor: convert grails-logging, grails-quartz, grails-startup-progress and grails-datasource to Groovy [grails-core]

Posted by "borinquenkid (via GitHub)" <gi...@apache.org>.

borinquenkid commented on PR #16590:
URL: https://github.com/apache/grails-core/pull/16590#issuecomment-6280546414

**Update: this branch now carries a different temporary CI commit (BLOCKER before merge).**

The earlier `skipTests`/`skipCodeStyle` flag in `gradle.properties` did not help enough: the functional jobs still compile the whole repository (about 57 minutes each) on every push, so it only saved around a fifth of the time. It has been removed.

In its place, every PR in this stack except #16576 (the one closest to 10.0.x) carries one temporary commit, `CHANGEME FOR ACCEPTANCE: disable PR workflow triggers`. It changes the `pull_request:` trigger of each workflow to `branches: ['CHANGEME-FOR-ACCEPTANCE']`, a branch that does not exist, so pushing, rebasing or force-pushing this branch starts no jobs.

**Condition for merging this PR:** that commit must be reverted on this branch first (`git revert` of the `CHANGEME FOR ACCEPTANCE` commit), and CI must then run and be green. **The absence of CI checks on this PR is deliberate and does not mean the code was tested.** The full build runs on #16576, and each PR gets it when the PR below it has merged.

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org