You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@creadur.apache.org by rd...@apache.org on 2011/07/11 15:39:47 UTC
svn commit: r1145172 - in /incubator/rat/eye/trunk:
org/apache/rat/eye/engine.py test/test_engine.py
Author: rdonkin
Date: Mon Jul 11 13:39:47 2011
New Revision: 1145172
URL: http://svn.apache.org/viewvc?rev=1145172&view=rev
Log:
Reviewer repeats review for every item in list.
Modified:
incubator/rat/eye/trunk/org/apache/rat/eye/engine.py
incubator/rat/eye/trunk/test/test_engine.py
Modified: incubator/rat/eye/trunk/org/apache/rat/eye/engine.py
URL: http://svn.apache.org/viewvc/incubator/rat/eye/trunk/org/apache/rat/eye/engine.py?rev=1145172&r1=1145171&r2=1145172&view=diff
==============================================================================
--- incubator/rat/eye/trunk/org/apache/rat/eye/engine.py (original)
+++ incubator/rat/eye/trunk/org/apache/rat/eye/engine.py Mon Jul 11 13:39:47 2011
@@ -222,6 +222,32 @@ class AccumulativeScanner(Scanner):
if not (Directory is None or self.findings is None):
self.findings.append(directory)
+class MetaInfReviewer():
+ """
+ Reviews META-INF in jars.
+ """
+ def __init__(self, reviews):
+ self.reviews = reviews
+
+ def reviewJar(self, jar):
+ metainf = jar.metainf()
+ for review in self.reviews:
+ review.reviewMetaInf(metainf)
+
+class Reviewer():
+ """
+ Reviews artifacts.
+ """
+ def __init__(self, reviews = []):
+ self.reviews = reviews
+
+ def review(self, list):
+ for item in list:
+ if (hasattr(item, "reportTo")):
+ for review in self.reviews:
+ item.reportTo(review)
+ return self
+
class Reports():
"""
Collects reports.
@@ -322,4 +348,4 @@ class Jar(Artifact, ZipContainer):
Artifact.reportTo(self, reviewer)
if (hasattr(reviewer, "reviewJar")):
reviewer.reviewJar(self)
-
+ return self
Modified: incubator/rat/eye/trunk/test/test_engine.py
URL: http://svn.apache.org/viewvc/incubator/rat/eye/trunk/test/test_engine.py?rev=1145172&r1=1145171&r2=1145172&view=diff
==============================================================================
--- incubator/rat/eye/trunk/test/test_engine.py (original)
+++ incubator/rat/eye/trunk/test/test_engine.py Mon Jul 11 13:39:47 2011
@@ -23,6 +23,13 @@ import os.path
from org.apache.rat.eye import engine
from zipfile import ZipFile
+class AMetaInfReview():
+ def __init__(self):
+ self.metainfs = []
+
+ def reviewMetaInf(self, metainf):
+ self.metainfs.append(metainf);
+
class AReviewer():
def __init__(self):
self.jars = []
@@ -254,6 +261,22 @@ class TestEngine(unittest.TestCase):
self.assertEquals(subject.blockers, blockers + extra_blockers)
self.assertEquals(subject.hazards, hazards + extra_hazards)
self.assertEquals(subject.info, info + extra_info)
+
+ def testReviewerSmokeOrChoke(self):
+ engine.Reviewer([]).review([])
+ def testReviewerReview(self):
+ aJar = engine.Jar(".", "whatever.jar")
+ subject = engine.Reviewer([AReviewer()]).review([aJar])
+ self.assertEquals(subject.reviews[0].jars, [aJar])
+ self.assertEquals(subject.reviews[0].dirs, [])
+ self.assertEquals(subject.reviews[0].artifacts, [aJar])
+
+ def testMetaInfReviewerDoReviewJar(self):
+ testSpy = AMetaInfReview()
+ subject = engine.MetaInfReviewer([testSpy])
+ jar = engine.Jar("test", "bogo-justajar-0.1.jar").reportTo(subject)
+ self.assertEquals(testSpy.metainfs, [jar.metainf()])
+
if __name__ == '__main__':
unittest.main()
\ No newline at end of file