You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/11/19 00:46:44 UTC

[GitHub] [incubator-superset] rusackas opened a new pull request #8596: [css] Simplifying SQL toolbar item margins, fixing overflow bug

rusackas opened a new pull request #8596: [css] Simplifying SQL toolbar item margins, fixing overflow bug
URL: https://github.com/apache/incubator-superset/pull/8596
 
 
   ### CATEGORY
   
   Choose one
   
   - [x] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [x] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   I noticed in the demo of the query cost estimator feature that there were some weird overflow issues when the buttons were forced to linewrap, covering the content below. This PR fixes that issue. This PR also adds more consistent margins to those toolbar items, whether linewrapped or not, with simplified CSS (e.g. less utilization of utility classes).
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Before (wide)
   <img width="950" alt="Screen Shot 2019-11-18 at 4 37 14 PM" src="https://user-images.githubusercontent.com/812905/69106299-c0eaca80-0a22-11ea-98b1-ff0e6fea6545.png">
   Before (narrow)
   <img width="386" alt="Screen Shot 2019-11-18 at 4 41 30 PM" src="https://user-images.githubusercontent.com/812905/69106311-cd6f2300-0a22-11ea-89b4-b789df7beeed.png">
   
   After (wide)
   <img width="850" alt="Screen Shot 2019-11-18 at 4 38 59 PM" src="https://user-images.githubusercontent.com/812905/69106324-d829b800-0a22-11ea-889f-f95ee60cf5ad.png">
   After (narrow)
   <img width="347" alt="Screen Shot 2019-11-18 at 4 39 21 PM" src="https://user-images.githubusercontent.com/812905/69106337-e1b32000-0a22-11ea-9035-4a142f001363.png">
   
   ### TEST PLAN
   Manual testing
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [x] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   @mistercrunch 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org