Re: [PR] [HUDI-7013] Drop table command cannot delete dir even when purge is enable [hudi]

["danny0405 (via GitHub)" <gi...@apache.org>]

danny0405 commented on code in PR #9960:
URL: https://github.com/apache/hudi/pull/9960#discussion_r1378275438


##########
hudi-common/src/main/java/org/apache/hudi/common/fs/FSUtils.java:
##########
@@ -699,7 +699,7 @@ public static boolean deleteDir(
             pairOfSubPathAndConf -> deleteSubPath(
                 pairOfSubPathAndConf.getKey(), pairOfSubPathAndConf.getValue(), true)
         );
-        boolean result = fs.delete(dirPath, false);
+        boolean result = fs.delete(dirPath, true);

Review Comment:
   I'm confused, this deletion happens recursely from sub-dir to parent dir, why we need the `true` flag then?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org