You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2019/07/16 15:28:21 UTC

[Bug 63567] New: catalina.sh fails to pass LOGGING_MANAGER to jvm during stop

https://bz.apache.org/bugzilla/show_bug.cgi?id=63567

            Bug ID: 63567
           Summary: catalina.sh fails to pass LOGGING_MANAGER to jvm
                    during stop
           Product: Tomcat 8
           Version: 8.5.41
          Hardware: All
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Catalina
          Assignee: dev@tomcat.apache.org
          Reporter: erempel@uvic.ca
  Target Milestone: ----

If LOGGING_MANAGER is set (in setenv.sh) startup processing works correctly,
but during shutdown (catalina.sh stop) a number of errors are logged regarding
logging plugins failing to be created.

 main ERROR Could not create plugin of type class
org.apache.logging.log4j.core.appender.FileAppender for element File:
java.lang.ClassCastException:
org.apache.logging.log4j.core.appender.FileManager$FactoryData cannot be cast
to
org.apache.logging.log4j.core.appender.rolling.RollingFileManager$FactoryData
java.lang.ClassCastException:
org.apache.logging.log4j.core.appender.FileManager$FactoryData cannot be cast
to
org.apache.logging.log4j.core.appender.rolling.RollingFileManager$FactoryData

Adding the LOGGING_MANAGER to the eval of the java runtime in the "stop" case
of catalina.sh resolves this.

Line 519 of catalina.sh

change

  eval "\"$_RUNJAVA\"" $JAVA_OPTS \
    -D$ENDORSED_PROP="\"$JAVA_ENDORSED_DIRS\"" \
    -classpath "\"$CLASSPATH\"" \
    -Dcatalina.base="\"$CATALINA_BASE\"" \
    -Dcatalina.home="\"$CATALINA_HOME\"" \
    -Djava.io.tmpdir="\"$CATALINA_TMPDIR\"" \
    org.apache.catalina.startup.Bootstrap "$@" stop


to

  eval "\"$_RUNJAVA\"" $LOGGING_MANAGER $JAVA_OPTS \
    -D$ENDORSED_PROP="\"$JAVA_ENDORSED_DIRS\"" \
    -classpath "\"$CLASSPATH\"" \
    -Dcatalina.base="\"$CATALINA_BASE\"" \
    -Dcatalina.home="\"$CATALINA_HOME\"" \
    -Djava.io.tmpdir="\"$CATALINA_TMPDIR\"" \
    org.apache.catalina.startup.Bootstrap "$@" stop

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 63567] catalina.sh fails to pass LOGGING_MANAGER to jvm during stop

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63567

--- Comment #2 from Mark Thomas <ma...@apache.org> ---
Given the timing of the fix mention in comment #1 (2 years before Java 9 GA)
that issue looks like an issue in the EA releases that was addressed by GA. On
that basis, restoring the $LOGGING_MANAGER looks like the best course of action
here.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 63567] catalina.sh fails to pass LOGGING_MANAGER to jvm during stop

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63567

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Mark Thomas <ma...@apache.org> ---
Fixed in:
- master for 9.0.23 onwards
- 8.5.x for 8.5.44 onwards

7.0.x was not affected.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 63567] catalina.sh fails to pass LOGGING_MANAGER to jvm during stop

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63567

--- Comment #1 from Mark Thomas <ma...@apache.org> ---
This was removed because it was causing issues with Java 9:
https://github.com/apache/tomcat/commit/ff57a28661ee6e581dff17e362864910efed426b

There is also the point of multiple processes trying to write to the same file.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org