You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/03/27 09:20:03 UTC

[GitHub] [cloudstack-primate] shwstppr opened a new pull request #264: view: fix user change password

shwstppr opened a new pull request #264: view: fix user change password
URL: https://github.com/apache/cloudstack-primate/pull/264
 
 
   Added custom form with the conditional current password field
   
   For Admin/Domain admin
   ![Screenshot from 2020-03-27 14-48-28](https://user-images.githubusercontent.com/153340/77740921-191d8300-703a-11ea-9ba9-79024be56021.png)
   For Normal user
   ![Screenshot from 2020-03-27 14-47-58](https://user-images.githubusercontent.com/153340/77740927-1c187380-703a-11ea-91fb-7c157e92d04a.png)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #264: view: fix user change password

Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #264: view: fix user change password
URL: https://github.com/apache/cloudstack-primate/pull/264#discussion_r399137163
 
 

 ##########
 File path: src/locales/en.json
 ##########
 @@ -1103,7 +1106,6 @@
 "sshKeyPairs": "SSH keypairs",
 "wednesday": "Wednesday",
 "noselect": "No thanks",
-"group": "Group",
 
 Review comment:
   `group` is used in VM wizard, check and unremove it @shwstppr 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack-primate] shwstppr commented on a change in pull request #264: view: fix user change password

Posted by GitBox <gi...@apache.org>.
shwstppr commented on a change in pull request #264: view: fix user change password
URL: https://github.com/apache/cloudstack-primate/pull/264#discussion_r399138955
 
 

 ##########
 File path: src/locales/en.json
 ##########
 @@ -1103,7 +1106,6 @@
 "sshKeyPairs": "SSH keypairs",
 "wednesday": "Wednesday",
 "noselect": "No thanks",
-"group": "Group",
 
 Review comment:
   already present above in the file
   https://github.com/apache/cloudstack-primate/blob/fd882b35a9a547f8a104d5ddeef34b9058ccb9a8/src/locales/en.json#L234
   this was duplicate @rhtyd 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack-primate] shwstppr commented on issue #264: view: fix user change password

Posted by GitBox <gi...@apache.org>.
shwstppr commented on issue #264: view: fix user change password
URL: https://github.com/apache/cloudstack-primate/pull/264#issuecomment-615039416
 
 
   @rhtyd can be reviewed

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services