You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apr.apache.org by "Philip M. Gollucci" <pg...@ridecharge.com> on 2008/07/08 19:53:45 UTC
RE: ports/125400: devel/apr APR_UTIL_WITH_LDAP=yes building is broken
Hi All,
as you can see the recent update of devel/apr from 1.2.12 to 1.3.2
breaks apr-util when building with LDAP on FreeBSD. The log is from a
FreeBSD tinderbox, but can reproduced with the normal build steps.
The attached patch fixes it both in and out of tinderbox.
This particular diff is against branches/1.3.x but build/apu-conf.m4
is identical on trunk so it should apply there too.
I'll submit a FreeBSD PR to fix the port so it doesn't have to wait for
1.3.3 next.
--
------------------------------------------------------------------------
Philip M. Gollucci (philip@ridecharge.com)
o:703.549.2050x206
Senior System Admin - Riderway, Inc.
http://riderway.com / http://ridecharge.com
1024D/DB9B8C1C B90B FBC3 A3A1 C71A 8E70 3F8C 75B8 8FFB DB9B 8C1C
Work like you don't need the money,
love like you'll never get hurt,
and dance like nobody's watching.
Re: ports/125400: devel/apr APR_UTIL_WITH_LDAP=yes building is
broken
Posted by Bojan Smojver <bo...@rexursive.com>.
On Tue, 2008-07-08 at 17:18 -0400, Philip M. Gollucci wrote:
> + CPPFLAGS=$save_cppflags
> + LDFLAGS=$save_ldflags
> + LIBS=$save_libs
Committed with quotes applied above. Thanks for the patch!
--
Bojan
Re: ports/125400: devel/apr APR_UTIL_WITH_LDAP=yes building is broken
Posted by "Philip M. Gollucci" <pg...@p6m7g8.com>.
Ruediger Pluem wrote:
> Yes please. For ease of appliance and track of record.
Attached.
TIA
Re: ports/125400: devel/apr APR_UTIL_WITH_LDAP=yes building is broken
Posted by Ruediger Pluem <rp...@apache.org>.
On 07/08/2008 09:23 PM, Philip M. Gollucci wrote:
> Ruediger Pluem wrote:
>> if test "$apu_has_ldap_openldap" = "1"; then
>> + CPPFLAGS=$save_cppflags
>> + LDFLAGS=$save_ldflags
>> + LIBS=$save_libs
>>
>> Shouldn't this be the other way round such that you *safe* the old values
>> of CPPFLAGS, LDFLAGS and LIBS for later restore in the safe* variables?
> You are absolutely right. I can't believe I cut/pasted that...
>
> *sigh*....
>
> worth another diff ?
Yes please. For ease of appliance and track of record.
Regards
Rüdiger
Re: ports/125400: devel/apr APR_UTIL_WITH_LDAP=yes building is broken
Posted by "Philip M. Gollucci" <pg...@p6m7g8.com>.
Ruediger Pluem wrote:
> if test "$apu_has_ldap_openldap" = "1"; then
> + CPPFLAGS=$save_cppflags
> + LDFLAGS=$save_ldflags
> + LIBS=$save_libs
>
> Shouldn't this be the other way round such that you *safe* the old values
> of CPPFLAGS, LDFLAGS and LIBS for later restore in the safe* variables?
You are absolutely right. I can't believe I cut/pasted that...
*sigh*....
worth another diff ?
Re: ports/125400: devel/apr APR_UTIL_WITH_LDAP=yes building is broken
Posted by Ruediger Pluem <rp...@apache.org>.
On 07/08/2008 07:55 PM, Philip M. Gollucci wrote:
> Resending from an address that will make it through to lists.
>
> Philip M. Gollucci wrote:
>> Hi All,
>>
>> as you can see the recent update of devel/apr from 1.2.12 to 1.3.2
>> breaks apr-util when building with LDAP on FreeBSD. The log is from a
>> FreeBSD tinderbox, but can reproduced with the normal build steps.
>>
>> The attached patch fixes it both in and out of tinderbox.
>> This particular diff is against branches/1.3.x but build/apu-conf.m4
>> is identical on trunk so it should apply there too.
>>
>> I'll submit a FreeBSD PR to fix the port so it doesn't have to wait
>> for 1.3.3 next.
>>
>
Index: build/apu-conf.m4
===================================================================
--- build/apu-conf.m4 (revision 674869)
+++ build/apu-conf.m4 (working copy)
@@ -357,6 +357,12 @@
])
if test "$apu_has_ldap_openldap" = "1"; then
+ CPPFLAGS=$save_cppflags
+ LDFLAGS=$save_ldflags
+ LIBS=$save_libs
Shouldn't this be the other way round such that you *safe* the old values
of CPPFLAGS, LDFLAGS and LIBS for later restore in the safe* variables?
+
+ CPPFLAGS="$CPPFLAGS $APRUTIL_INCLUDES"
+ LDFLAGS="$LDFLAGS $APRUTIL_LDFLAGS"
AC_CACHE_CHECK([style of ldap_set_rebind_proc routine], ac_cv_ldap_set_rebind_proc_style,
APR_TRY_COMPILE_NO_WARNING([
#ifdef HAVE_LBER_H
@@ -374,6 +380,10 @@
if test "$ac_cv_ldap_set_rebind_proc_style" = "three"; then
AC_DEFINE(LDAP_SET_REBIND_PROC_THREE, 1, [Define if ldap_set_rebind_proc takes three arguments])
fi
+
+ CPPFLAGS=$save_cppflags
+ LDFLAGS=$save_ldflags
+ LIBS=$save_libs
fi
AC_SUBST(ldap_h)
Regards
Rüdiger
Re: ports/125400: devel/apr APR_UTIL_WITH_LDAP=yes building is broken
Posted by "Philip M. Gollucci" <pg...@p6m7g8.com>.
Resending from an address that will make it through to lists.
Philip M. Gollucci wrote:
> Hi All,
>
> as you can see the recent update of devel/apr from 1.2.12 to 1.3.2
> breaks apr-util when building with LDAP on FreeBSD. The log is from a
> FreeBSD tinderbox, but can reproduced with the normal build steps.
>
> The attached patch fixes it both in and out of tinderbox.
> This particular diff is against branches/1.3.x but build/apu-conf.m4
> is identical on trunk so it should apply there too.
>
> I'll submit a FreeBSD PR to fix the port so it doesn't have to wait for
> 1.3.3 next.
>