You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@avro.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2023/06/15 16:32:00 UTC
[jira] [Commented] (AVRO-3473) Automatically register Conversion classes
[ https://issues.apache.org/jira/browse/AVRO-3473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17733165#comment-17733165 ]
ASF subversion and git services commented on AVRO-3473:
-------------------------------------------------------
Commit 72beda3f40a72f898fbe0bf0057c5612a582f71e in avro's branch refs/heads/master from Oscar Westra van Holthe - Kind
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=72beda3f4 ]
AVRO-3473: ServiceLoader for Conversion (#1624)
* AVRO-3473: ServiceLoader for Conversion
Automatically register Conversion classes using the Java 6 service
loader upon startup. This works for any Conversion that does not need
constructor parameters.
* AVRO-3473: ServiceLoader for Conversion
Improved variable name.
* AVRO-3473: Spotless
* Apply suggestions from code review
Co-authored-by: Ryan Skraba <ry...@skraba.com>
* AVRO-3473: Removed newline to trigger build
* AVRO-3473: Add missing import
No idea when that got dropped...
* AVRO-3473: Removed unused import
* AVRO-3473: Fix rebase errors
* Fix static imports
---------
Co-authored-by: Ryan Skraba <ry...@skraba.com>
> Automatically register Conversion<T> classes
> --------------------------------------------
>
> Key: AVRO-3473
> URL: https://issues.apache.org/jira/browse/AVRO-3473
> Project: Apache Avro
> Issue Type: Improvement
> Components: java, logical types
> Reporter: Oscar Westra van Holthe - Kind
> Assignee: Oscar Westra van Holthe - Kind
> Priority: Minor
> Labels: pull-request-available
> Fix For: 1.11.2
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Manually registering a {{Conversion<T>}} is cumbersome, but necessary if creating the factory requires constructor parameters.
> For most cases though, a {{Conversion<T>}} gets all the information it needs from the schema. This makes it a good candidate for a SPI (using the Java 6 {{ServiceLoader}} class).
> This is the addendum to AVRO-3441, which does the same thing for {{{}LogicalTypeFactory{}}}.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)