[GitHub] [calcite] zoudan commented on a diff in pull request #3214: [CALCITE-5608] Implement ASINH, ACOSH, ATANH functions

["zoudan (via GitHub)" <gi...@apache.org>]

zoudan commented on code in PR #3214:
URL: https://github.com/apache/calcite/pull/3214#discussion_r1202480641


##########
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##########
@@ -1854,6 +1854,21 @@ public static double acos(double b0) {
     return Math.acos(b0);
   }
 
+  // ACOSH
+  /** SQL <code>ACOSH</code> operator applied to BigDecimal values. */
+  public static double acosh(BigDecimal b0) {
+    return acosh(b0.doubleValue());
+  }
+
+  /** SQL <code>ACOSH</code> operator applied to double values. */
+  public static double acosh(double b0) {
+    if (b0 < 1) {
+      SQLException e = new SQLException("Input parameter of acosh cannot be small than 1!");

Review Comment:
   Thanks, I will update it soon



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org