[GitHub] [incubator-superset] etr2460 commented on a change in pull request #7895: [dashboard] fix chart showing loading icon when immune fields updated

[GitBox <gi...@apache.org>]

etr2460 commented on a change in pull request #7895: [dashboard] fix chart showing loading icon when immune fields updated
URL: https://github.com/apache/incubator-superset/pull/7895#discussion_r306044563
 
 

 ##########
 File path: superset/assets/src/dashboard/components/Dashboard.jsx
 ##########
 @@ -143,11 +144,32 @@ class Dashboard extends React.PureComponent {
   }
 
   refreshExcept(filterKey) {
-    const immune = this.props.dashboardInfo.metadata.filter_immune_slices || [];
+    const { filters } = this.props.dashboardState || {};
+    const currentFilteredNames =
+      filterKey && filters[filterKey] ? Object.keys(filters[filterKey]) : [];
+    const filter_immune_slices = this.props.dashboardInfo.metadata
+      .filter_immune_slices;
+    const filter_immune_slice_fields = this.props.dashboardInfo.metadata
 
 Review comment:
   camelCase for the const

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org