You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2019/12/20 16:23:30 UTC
[GitHub] [logging-log4j2] ahr-huber opened a new pull request #323: LOG4J2-2741 - Fix race condition in computation of prevFireTime in Cr…
ahr-huber opened a new pull request #323: LOG4J2-2741 - Fix race condition in computation of prevFireTime in Cr…
URL: https://github.com/apache/logging-log4j2/pull/323
…onTriggeringPolicy
There was a race condition in the computation of prevFireTime - which is used as time
for the file pattern - could be wrong which lead to the possibility of overwriting files,
because a file name could be generated twice. The cause was CronExpression.getPrevFireTime()
needs a Date in the interval (prevFireTime, currentFireTime], but the Date provided was
created at or after the currentFireTime.
Fixed by using the exact currentFireTime as provided by the scheduler.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [logging-log4j2] ahr-huber closed pull request #323: LOG4J2-2741 - Fix race condition in computation of prevFireTime in Cr…
Posted by GitBox <gi...@apache.org>.
ahr-huber closed pull request #323: LOG4J2-2741 - Fix race condition in computation of prevFireTime in Cr…
URL: https://github.com/apache/logging-log4j2/pull/323
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [logging-log4j2] ahr-huber commented on issue #323: LOG4J2-2741 - Fix race condition in computation of prevFireTime in Cr…
Posted by GitBox <gi...@apache.org>.
ahr-huber commented on issue #323: LOG4J2-2741 - Fix race condition in computation of prevFireTime in Cr…
URL: https://github.com/apache/logging-log4j2/pull/323#issuecomment-571493853
Closing. Turned out this was already fixed on master. Ticket was LOG4J2-2575. The fix from master was cherry picked.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services