You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "mathewjacob1002 (via GitHub)" <gi...@apache.org> on 2023/08/04 17:44:19 UTC

[GitHub] [spark] mathewjacob1002 opened a new pull request, #42347: [Spark Ticket][Python] Adding Deepspeed To The Test Dockerfile

mathewjacob1002 opened a new pull request, #42347:
URL: https://github.com/apache/spark/pull/42347

   ### What changes were proposed in this pull request?
   Added tests to the Dockerfile for tests in OSS Spark CI.
   
   
   ### Why are the changes needed?
   They'll skip the deepspeed tests otherwise.
   
   
   ### Does this PR introduce _any_ user-facing change?
   Nope, testing infra. 
   
   
   ### How was this patch tested?
   Running the tests on machine.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] mathewjacob1002 commented on pull request #42347: [SPARK-44264][Python] Adding Deepspeed To The Test Dockerfile

Posted by "mathewjacob1002 (via GitHub)" <gi...@apache.org>.
mathewjacob1002 commented on PR #42347:
URL: https://github.com/apache/spark/pull/42347#issuecomment-1665972551

   Created to address concerns from [Deepspeed E2E PR](https://github.com/apache/spark/pull/42118)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] zhengruifeng commented on pull request #42347: [SPARK-44264][PYTHON][ML][TESTS][FOLLOWUP] Adding Deepspeed To The Test Dockerfile

Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #42347:
URL: https://github.com/apache/spark/pull/42347#issuecomment-1667113237

   merged to master.
   
   there is merge conflict with branch-3.5, if this fix is needed in 3.5, please send a separate PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] zhengruifeng closed pull request #42347: [SPARK-44264][PYTHON][ML][TESTS][FOLLOWUP] Adding Deepspeed To The Test Dockerfile

Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng closed pull request #42347: [SPARK-44264][PYTHON][ML][TESTS][FOLLOWUP] Adding Deepspeed To The Test Dockerfile
URL: https://github.com/apache/spark/pull/42347


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org