[GitHub] [airflow] ashb commented on a change in pull request #9836: Fix Writing Serialized Dags to DB

[GitBox <gi...@apache.org>]

ashb commented on a change in pull request #9836:
URL: https://github.com/apache/airflow/pull/9836#discussion_r455115002



##########
File path: airflow/models/dagbag.py
##########
@@ -434,6 +436,10 @@ def sync_to_db(self):
         # To avoid circular import - airflow.models.dagbag -> airflow.models.dag -> airflow.models.dagbag
         from airflow.models.dag import DAG
         from airflow.models.serialized_dag import SerializedDagModel
+        self.log.debug("Calling the DAG.bulk_sync_to_db method")
         DAG.bulk_sync_to_db(self.dags.values())
-        if self.store_serialized_dags:
+        # Write Serialized DAGs to DB if DAG Serialization is turned on
+        # Even though self.store_serialized_dags is False
+        if settings.STORE_SERIALIZED_DAGS:

Review comment:
       Why do we want to do this? If we do this then wouldn't _every_ dagbag start writing to the DB?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org