You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "tustvold (via GitHub)" <gi...@apache.org> on 2023/01/24 12:06:06 UTC
[GitHub] [arrow-datafusion] tustvold opened a new issue, #5039: Use DataFusionError in SendableRecordBatchStream
tustvold opened a new issue, #5039:
URL: https://github.com/apache/arrow-datafusion/issues/5039
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
The is a significant amount of logic converting from DataFusionError to ArrowError and back, a large amount of which originates from the fact `SendableRecordBatchStream` returns `ArrowError` instead of `DataFusionError`
**Describe the solution you'd like**
It seems strange that the DataFusion stream abstraction would not return DataFusion's error type. I would like to change `SendableRecordBatchStream` to
```
pub trait RecordBatchStream: Stream<Item = Result<RecordBatch, DataFusionError>> {
/// Returns the schema of this `RecordBatchStream`.
///
/// Implementation of this trait should guarantee that all `RecordBatch`'s returned by this
/// stream should have the same schema as returned from this method.
fn schema(&self) -> SchemaRef;
}
```
**Describe alternatives you've considered**
We could not do this
**Additional context**
Add any other context or screenshots about the feature request here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] tustvold closed issue #5039: Use DataFusionError in SendableRecordBatchStream
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold closed issue #5039: Use DataFusionError in SendableRecordBatchStream
URL: https://github.com/apache/arrow-datafusion/issues/5039
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] comphead commented on issue #5039: Use DataFusionError in SendableRecordBatchStream
Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead commented on issue #5039:
URL: https://github.com/apache/arrow-datafusion/issues/5039#issuecomment-1402921483
That sounds good, we already have `DatafusionError` and `ArrowError` are not 1 to 1 match, but we can expand it if needed or still use `DatafusionError::ArrowError` to wrap Arrow errors. Hope I can crunch it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] crepererum commented on issue #5039: Use DataFusionError in SendableRecordBatchStream
Posted by "crepererum (via GitHub)" <gi...@apache.org>.
crepererum commented on issue #5039:
URL: https://github.com/apache/arrow-datafusion/issues/5039#issuecomment-1408755005
Dup of #4172.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org