You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/01/13 00:53:48 UTC
[GitHub] [lucene-solr] muse-dev[bot] commented on a change in pull request #2198: SOLR-15081: Metrics for core: isLeader, status
muse-dev[bot] commented on a change in pull request #2198:
URL: https://github.com/apache/lucene-solr/pull/2198#discussion_r556192502
##########
File path: solr/core/src/java/org/apache/solr/core/SolrCore.java
##########
@@ -1202,26 +1203,26 @@ public void initializeMetrics(SolrMetricsContext parentContext, String scope) {
parentContext.gauge(() -> isClosed() ? parentContext.nullString() : getIndexDir(), true, "indexDir", Category.CORE.toString());
parentContext.gauge(() -> isClosed() ? parentContext.nullNumber() : getIndexSize(), true, "sizeInBytes", Category.INDEX.toString());
parentContext.gauge(() -> isClosed() ? parentContext.nullString() : NumberUtils.readableSize(getIndexSize()), true, "size", Category.INDEX.toString());
- if (coreContainer != null) {
- final CloudDescriptor cd = getCoreDescriptor().getCloudDescriptor();
- if (cd != null) {
- parentContext.gauge(() -> {
- if (cd.getCollectionName() != null) {
- return cd.getCollectionName();
- } else {
- return parentContext.nullString();
- }
- }, true, "collection", Category.CORE.toString());
- parentContext.gauge(() -> {
- if (cd.getShardId() != null) {
- return cd.getShardId();
- } else {
- return parentContext.nullString();
- }
- }, true, "shard", Category.CORE.toString());
- }
+ final CloudDescriptor cd = getCoreDescriptor().getCloudDescriptor();
+ if (cd != null) {
+ // TODO
+ parentContext.gauge(cd::getCollectionName, true, "collection", Category.CORE.toString());
+ parentContext.gauge(() -> Objects.requireNonNullElse(cd.getShardId(), parentContext.nullString()), true, "shard", Category.CORE.toString());
+ //TODO should this instead be in a core status, or a metric? When do we use which?
+ // SEE org.apache.solr.handler.admin.CoreAdminOperation.getCoreStatus
+ parentContext.gauge(() -> {
+ DocCollection docColl = coreContainer.getZkController().getZkStateReader().getClusterState().getCollectionOrNull(cd.getCollectionName(), true);
+ Replica leaderReplica = docColl.getLeader(cd.getShardId());
Review comment:
*NULLPTR_DEREFERENCE:* accessing memory that is the null pointer on line 1215 indirectly during the call to `ClusterState.getCollectionOrNull(...)`.
##########
File path: solr/core/src/java/org/apache/solr/core/SolrCore.java
##########
@@ -1202,26 +1203,26 @@ public void initializeMetrics(SolrMetricsContext parentContext, String scope) {
parentContext.gauge(() -> isClosed() ? parentContext.nullString() : getIndexDir(), true, "indexDir", Category.CORE.toString());
parentContext.gauge(() -> isClosed() ? parentContext.nullNumber() : getIndexSize(), true, "sizeInBytes", Category.INDEX.toString());
parentContext.gauge(() -> isClosed() ? parentContext.nullString() : NumberUtils.readableSize(getIndexSize()), true, "size", Category.INDEX.toString());
- if (coreContainer != null) {
- final CloudDescriptor cd = getCoreDescriptor().getCloudDescriptor();
- if (cd != null) {
- parentContext.gauge(() -> {
- if (cd.getCollectionName() != null) {
- return cd.getCollectionName();
- } else {
- return parentContext.nullString();
- }
- }, true, "collection", Category.CORE.toString());
- parentContext.gauge(() -> {
- if (cd.getShardId() != null) {
- return cd.getShardId();
- } else {
- return parentContext.nullString();
- }
- }, true, "shard", Category.CORE.toString());
- }
+ final CloudDescriptor cd = getCoreDescriptor().getCloudDescriptor();
+ if (cd != null) {
+ // TODO
+ parentContext.gauge(cd::getCollectionName, true, "collection", Category.CORE.toString());
+ parentContext.gauge(() -> Objects.requireNonNullElse(cd.getShardId(), parentContext.nullString()), true, "shard", Category.CORE.toString());
+ //TODO should this instead be in a core status, or a metric? When do we use which?
+ // SEE org.apache.solr.handler.admin.CoreAdminOperation.getCoreStatus
+ parentContext.gauge(() -> {
+ DocCollection docColl = coreContainer.getZkController().getZkStateReader().getClusterState().getCollectionOrNull(cd.getCollectionName(), true);
+ Replica leaderReplica = docColl.getLeader(cd.getShardId());
+ return leaderReplica.getName().equals(cd.getCoreNodeName());
Review comment:
*NULLPTR_DEREFERENCE:* accessing memory that is the null pointer on line 1216 indirectly during the call to `DocCollection.getLeader(...)`.
##########
File path: solr/core/src/java/org/apache/solr/core/SolrCore.java
##########
@@ -1202,26 +1203,26 @@ public void initializeMetrics(SolrMetricsContext parentContext, String scope) {
parentContext.gauge(() -> isClosed() ? parentContext.nullString() : getIndexDir(), true, "indexDir", Category.CORE.toString());
parentContext.gauge(() -> isClosed() ? parentContext.nullNumber() : getIndexSize(), true, "sizeInBytes", Category.INDEX.toString());
parentContext.gauge(() -> isClosed() ? parentContext.nullString() : NumberUtils.readableSize(getIndexSize()), true, "size", Category.INDEX.toString());
- if (coreContainer != null) {
- final CloudDescriptor cd = getCoreDescriptor().getCloudDescriptor();
- if (cd != null) {
- parentContext.gauge(() -> {
- if (cd.getCollectionName() != null) {
- return cd.getCollectionName();
- } else {
- return parentContext.nullString();
- }
- }, true, "collection", Category.CORE.toString());
- parentContext.gauge(() -> {
- if (cd.getShardId() != null) {
- return cd.getShardId();
- } else {
- return parentContext.nullString();
- }
- }, true, "shard", Category.CORE.toString());
- }
+ final CloudDescriptor cd = getCoreDescriptor().getCloudDescriptor();
+ if (cd != null) {
+ // TODO
+ parentContext.gauge(cd::getCollectionName, true, "collection", Category.CORE.toString());
+ parentContext.gauge(() -> Objects.requireNonNullElse(cd.getShardId(), parentContext.nullString()), true, "shard", Category.CORE.toString());
+ //TODO should this instead be in a core status, or a metric? When do we use which?
+ // SEE org.apache.solr.handler.admin.CoreAdminOperation.getCoreStatus
+ parentContext.gauge(() -> {
+ DocCollection docColl = coreContainer.getZkController().getZkStateReader().getClusterState().getCollectionOrNull(cd.getCollectionName(), true);
+ Replica leaderReplica = docColl.getLeader(cd.getShardId());
+ return leaderReplica.getName().equals(cd.getCoreNodeName());
+ }, true, "isLeader", Category.CORE.toString());
+ parentContext.gauge(() -> {
+ DocCollection docColl = coreContainer.getZkController().getZkStateReader().getClusterState().getCollectionOrNull(cd.getCollectionName(), true);
+ final Replica myReplica = docColl.getReplica(cd.getCoreNodeName());
Review comment:
*NULLPTR_DEREFERENCE:* accessing memory that is the null pointer on line 1220 indirectly during the call to `ClusterState.getCollectionOrNull(...)`.
##########
File path: solr/core/src/java/org/apache/solr/core/SolrCore.java
##########
@@ -1202,26 +1203,26 @@ public void initializeMetrics(SolrMetricsContext parentContext, String scope) {
parentContext.gauge(() -> isClosed() ? parentContext.nullString() : getIndexDir(), true, "indexDir", Category.CORE.toString());
parentContext.gauge(() -> isClosed() ? parentContext.nullNumber() : getIndexSize(), true, "sizeInBytes", Category.INDEX.toString());
parentContext.gauge(() -> isClosed() ? parentContext.nullString() : NumberUtils.readableSize(getIndexSize()), true, "size", Category.INDEX.toString());
- if (coreContainer != null) {
- final CloudDescriptor cd = getCoreDescriptor().getCloudDescriptor();
- if (cd != null) {
- parentContext.gauge(() -> {
- if (cd.getCollectionName() != null) {
- return cd.getCollectionName();
- } else {
- return parentContext.nullString();
- }
- }, true, "collection", Category.CORE.toString());
- parentContext.gauge(() -> {
- if (cd.getShardId() != null) {
- return cd.getShardId();
- } else {
- return parentContext.nullString();
- }
- }, true, "shard", Category.CORE.toString());
- }
+ final CloudDescriptor cd = getCoreDescriptor().getCloudDescriptor();
+ if (cd != null) {
+ // TODO
+ parentContext.gauge(cd::getCollectionName, true, "collection", Category.CORE.toString());
+ parentContext.gauge(() -> Objects.requireNonNullElse(cd.getShardId(), parentContext.nullString()), true, "shard", Category.CORE.toString());
+ //TODO should this instead be in a core status, or a metric? When do we use which?
+ // SEE org.apache.solr.handler.admin.CoreAdminOperation.getCoreStatus
+ parentContext.gauge(() -> {
+ DocCollection docColl = coreContainer.getZkController().getZkStateReader().getClusterState().getCollectionOrNull(cd.getCollectionName(), true);
+ Replica leaderReplica = docColl.getLeader(cd.getShardId());
+ return leaderReplica.getName().equals(cd.getCoreNodeName());
+ }, true, "isLeader", Category.CORE.toString());
+ parentContext.gauge(() -> {
+ DocCollection docColl = coreContainer.getZkController().getZkStateReader().getClusterState().getCollectionOrNull(cd.getCollectionName(), true);
+ final Replica myReplica = docColl.getReplica(cd.getCoreNodeName());
+ return Objects.requireNonNullElse(myReplica.getState().toString(), parentContext.nullString());
Review comment:
*NULLPTR_DEREFERENCE:* accessing memory that is the null pointer on line 1221 indirectly during the call to `DocCollection.getReplica(...)`.
##########
File path: solr/core/src/java/org/apache/solr/core/SolrCore.java
##########
@@ -1202,26 +1203,26 @@ public void initializeMetrics(SolrMetricsContext parentContext, String scope) {
parentContext.gauge(() -> isClosed() ? parentContext.nullString() : getIndexDir(), true, "indexDir", Category.CORE.toString());
parentContext.gauge(() -> isClosed() ? parentContext.nullNumber() : getIndexSize(), true, "sizeInBytes", Category.INDEX.toString());
parentContext.gauge(() -> isClosed() ? parentContext.nullString() : NumberUtils.readableSize(getIndexSize()), true, "size", Category.INDEX.toString());
- if (coreContainer != null) {
- final CloudDescriptor cd = getCoreDescriptor().getCloudDescriptor();
- if (cd != null) {
- parentContext.gauge(() -> {
- if (cd.getCollectionName() != null) {
- return cd.getCollectionName();
- } else {
- return parentContext.nullString();
- }
- }, true, "collection", Category.CORE.toString());
- parentContext.gauge(() -> {
- if (cd.getShardId() != null) {
- return cd.getShardId();
- } else {
- return parentContext.nullString();
- }
- }, true, "shard", Category.CORE.toString());
- }
+ final CloudDescriptor cd = getCoreDescriptor().getCloudDescriptor();
+ if (cd != null) {
+ // TODO
+ parentContext.gauge(cd::getCollectionName, true, "collection", Category.CORE.toString());
+ parentContext.gauge(() -> Objects.requireNonNullElse(cd.getShardId(), parentContext.nullString()), true, "shard", Category.CORE.toString());
+ //TODO should this instead be in a core status, or a metric? When do we use which?
+ // SEE org.apache.solr.handler.admin.CoreAdminOperation.getCoreStatus
+ parentContext.gauge(() -> {
+ DocCollection docColl = coreContainer.getZkController().getZkStateReader().getClusterState().getCollectionOrNull(cd.getCollectionName(), true);
+ Replica leaderReplica = docColl.getLeader(cd.getShardId());
+ return leaderReplica.getName().equals(cd.getCoreNodeName());
+ }, true, "isLeader", Category.CORE.toString());
+ parentContext.gauge(() -> {
+ DocCollection docColl = coreContainer.getZkController().getZkStateReader().getClusterState().getCollectionOrNull(cd.getCollectionName(), true);
+ final Replica myReplica = docColl.getReplica(cd.getCoreNodeName());
+ return Objects.requireNonNullElse(myReplica.getState().toString(), parentContext.nullString());
Review comment:
*NULL_DEREFERENCE:* object `myReplica` last assigned on line 1221 could be null and is dereferenced at line 1222.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org