You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Dan Dumont <dd...@us.ibm.com> on 2011/12/07 17:43:05 UTC
Review Request: Update Open View APIs To Support Opening Of Views At
Specific Locations
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3053/
-----------------------------------------------------------
Review request for shindig, Ryan Baxter, Jason Chiang, and Stanton Sievers.
Summary
-------
Also updated the /samplecontainer/examples/embeddedexperiences/ container and gadgets to demonstrate how one might support the feature.
A spec update will be written up to account for these changes.
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/EEContainer.js 1211472
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/PhotoList.xml 1211472
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements-container.js 1211478
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/open-views/viewEnhancements-test.js 1211472
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements.js 1211472
Diff: https://reviews.apache.org/r/3053/diff
Testing
-------
all tests pass, added a jsunit test case.
Thanks,
Dan
Re: Review Request: Update Open View APIs To Support Opening Of Views At
Specific Locations
Posted by Jason Chiang <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3053/#review3847
-----------------------------------------------------------
LGTM
- Jason
On 2011-12-07 16:53:27, Dan Dumont wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3053/
> -----------------------------------------------------------
>
> (Updated 2011-12-07 16:53:27)
>
>
> Review request for shindig, Ryan Baxter, Jason Chiang, and Stanton Sievers.
>
>
> Summary
> -------
>
> Also updated the /samplecontainer/examples/embeddedexperiences/ container and gadgets to demonstrate how one might support the feature.
>
> A spec update will be written up to account for these changes.
>
>
> This addresses bug SHINDIG-1671.
> https://issues.apache.org/jira/browse/SHINDIG-1671
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/EEContainer.js 1211472
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/PhotoList.xml 1211472
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements-container.js 1211478
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/open-views/viewEnhancements-test.js 1211472
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements.js 1211472
>
> Diff: https://reviews.apache.org/r/3053/diff
>
>
> Testing
> -------
>
> all tests pass, added a jsunit test case.
>
>
> Thanks,
>
> Dan
>
>
Re: Review Request: Update Open View APIs To Support Opening Of Views At
Specific Locations
Posted by Dan Dumont <dd...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3053/#review3877
-----------------------------------------------------------
Thanks all for the reviews.
I plan on committing this on Wednesday, so if you'd like to review but won't have time let me know and I can hold off.
- Dan
On 2011-12-07 16:53:27, Dan Dumont wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3053/
> -----------------------------------------------------------
>
> (Updated 2011-12-07 16:53:27)
>
>
> Review request for shindig, Ryan Baxter, Jason Chiang, and Stanton Sievers.
>
>
> Summary
> -------
>
> Also updated the /samplecontainer/examples/embeddedexperiences/ container and gadgets to demonstrate how one might support the feature.
>
> A spec update will be written up to account for these changes.
>
>
> This addresses bug SHINDIG-1671.
> https://issues.apache.org/jira/browse/SHINDIG-1671
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/EEContainer.js 1211472
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/PhotoList.xml 1211472
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements-container.js 1211478
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/open-views/viewEnhancements-test.js 1211472
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements.js 1211472
>
> Diff: https://reviews.apache.org/r/3053/diff
>
>
> Testing
> -------
>
> all tests pass, added a jsunit test case.
>
>
> Thanks,
>
> Dan
>
>
Re: Review Request: Update Open View APIs To Support Opening Of Views At
Specific Locations
Posted by Ryan Baxter <rb...@gmail.com>.
> On 2011-12-07 23:13:36, Ryan Baxter wrote:
> > http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/EEContainer.js, line 33
> > <https://reviews.apache.org/r/3053/diff/2/?file=62850#file62850line33>
> >
> > I thought we were going to allot this for floats and dialogs?
>
> Dan Dumont wrote:
> I figured we could have this discussion here.
>
> In the spec language, I would prefer to say that containers SHOULD consider coordinates passed in to this method if the target is FLOAT. And that if the target is anything else, containers MAY consider the coordinates.
>
> Dialogs are a bit heavy weight, and most containers will probably want to control where they pop up and how they look.
> Floats seem to be to be lighter weight, probably with little to no gadget chrome.
After taking a second look at this, I realized this code was in the EE sample container, so really the decision over what view types they honor this for is up to the container, is that correct?
- Ryan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3053/#review3718
-----------------------------------------------------------
On 2011-12-07 16:53:27, Dan Dumont wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3053/
> -----------------------------------------------------------
>
> (Updated 2011-12-07 16:53:27)
>
>
> Review request for shindig, Ryan Baxter, Jason Chiang, and Stanton Sievers.
>
>
> Summary
> -------
>
> Also updated the /samplecontainer/examples/embeddedexperiences/ container and gadgets to demonstrate how one might support the feature.
>
> A spec update will be written up to account for these changes.
>
>
> This addresses bug SHINDIG-1671.
> https://issues.apache.org/jira/browse/SHINDIG-1671
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/EEContainer.js 1211472
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/PhotoList.xml 1211472
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements-container.js 1211478
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/open-views/viewEnhancements-test.js 1211472
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements.js 1211472
>
> Diff: https://reviews.apache.org/r/3053/diff
>
>
> Testing
> -------
>
> all tests pass, added a jsunit test case.
>
>
> Thanks,
>
> Dan
>
>
Re: Review Request: Update Open View APIs To Support Opening Of Views At
Specific Locations
Posted by Dan Dumont <dd...@us.ibm.com>.
> On 2011-12-07 23:13:36, Ryan Baxter wrote:
> > http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/EEContainer.js, line 33
> > <https://reviews.apache.org/r/3053/diff/2/?file=62850#file62850line33>
> >
> > I thought we were going to allot this for floats and dialogs?
>
> Dan Dumont wrote:
> I figured we could have this discussion here.
>
> In the spec language, I would prefer to say that containers SHOULD consider coordinates passed in to this method if the target is FLOAT. And that if the target is anything else, containers MAY consider the coordinates.
>
> Dialogs are a bit heavy weight, and most containers will probably want to control where they pop up and how they look.
> Floats seem to be to be lighter weight, probably with little to no gadget chrome.
>
> Ryan Baxter wrote:
> After taking a second look at this, I realized this code was in the EE sample container, so really the decision over what view types they honor this for is up to the container, is that correct?
Yes. Though in the spec we strongly suggest doing it for FLOAT and completely optional for everything else.
- Dan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3053/#review3718
-----------------------------------------------------------
On 2011-12-07 16:53:27, Dan Dumont wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3053/
> -----------------------------------------------------------
>
> (Updated 2011-12-07 16:53:27)
>
>
> Review request for shindig, Ryan Baxter, Jason Chiang, and Stanton Sievers.
>
>
> Summary
> -------
>
> Also updated the /samplecontainer/examples/embeddedexperiences/ container and gadgets to demonstrate how one might support the feature.
>
> A spec update will be written up to account for these changes.
>
>
> This addresses bug SHINDIG-1671.
> https://issues.apache.org/jira/browse/SHINDIG-1671
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/EEContainer.js 1211472
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/PhotoList.xml 1211472
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements-container.js 1211478
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/open-views/viewEnhancements-test.js 1211472
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements.js 1211472
>
> Diff: https://reviews.apache.org/r/3053/diff
>
>
> Testing
> -------
>
> all tests pass, added a jsunit test case.
>
>
> Thanks,
>
> Dan
>
>
Re: Review Request: Update Open View APIs To Support Opening Of Views At
Specific Locations
Posted by Dan Dumont <dd...@us.ibm.com>.
> On 2011-12-07 23:13:36, Ryan Baxter wrote:
> > http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/EEContainer.js, line 33
> > <https://reviews.apache.org/r/3053/diff/2/?file=62850#file62850line33>
> >
> > I thought we were going to allot this for floats and dialogs?
I figured we could have this discussion here.
In the spec language, I would prefer to say that containers SHOULD consider coordinates passed in to this method if the target is FLOAT. And that if the target is anything else, containers MAY consider the coordinates.
Dialogs are a bit heavy weight, and most containers will probably want to control where they pop up and how they look.
Floats seem to be to be lighter weight, probably with little to no gadget chrome.
- Dan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3053/#review3718
-----------------------------------------------------------
On 2011-12-07 16:53:27, Dan Dumont wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3053/
> -----------------------------------------------------------
>
> (Updated 2011-12-07 16:53:27)
>
>
> Review request for shindig, Ryan Baxter, Jason Chiang, and Stanton Sievers.
>
>
> Summary
> -------
>
> Also updated the /samplecontainer/examples/embeddedexperiences/ container and gadgets to demonstrate how one might support the feature.
>
> A spec update will be written up to account for these changes.
>
>
> This addresses bug SHINDIG-1671.
> https://issues.apache.org/jira/browse/SHINDIG-1671
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/EEContainer.js 1211472
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/PhotoList.xml 1211472
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements-container.js 1211478
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/open-views/viewEnhancements-test.js 1211472
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements.js 1211472
>
> Diff: https://reviews.apache.org/r/3053/diff
>
>
> Testing
> -------
>
> all tests pass, added a jsunit test case.
>
>
> Thanks,
>
> Dan
>
>
Re: Review Request: Update Open View APIs To Support Opening Of Views At
Specific Locations
Posted by Ryan Baxter <rb...@gmail.com>.
> On 2011-12-07 23:13:36, Ryan Baxter wrote:
> > http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/EEContainer.js, line 33
> > <https://reviews.apache.org/r/3053/diff/2/?file=62850#file62850line33>
> >
> > I thought we were going to allot this for floats and dialogs?
>
> Dan Dumont wrote:
> I figured we could have this discussion here.
>
> In the spec language, I would prefer to say that containers SHOULD consider coordinates passed in to this method if the target is FLOAT. And that if the target is anything else, containers MAY consider the coordinates.
>
> Dialogs are a bit heavy weight, and most containers will probably want to control where they pop up and how they look.
> Floats seem to be to be lighter weight, probably with little to no gadget chrome.
>
> Ryan Baxter wrote:
> After taking a second look at this, I realized this code was in the EE sample container, so really the decision over what view types they honor this for is up to the container, is that correct?
>
> Dan Dumont wrote:
> Yes. Though in the spec we strongly suggest doing it for FLOAT and completely optional for everything else.
I am fine with that.
- Ryan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3053/#review3718
-----------------------------------------------------------
On 2011-12-07 16:53:27, Dan Dumont wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3053/
> -----------------------------------------------------------
>
> (Updated 2011-12-07 16:53:27)
>
>
> Review request for shindig, Ryan Baxter, Jason Chiang, and Stanton Sievers.
>
>
> Summary
> -------
>
> Also updated the /samplecontainer/examples/embeddedexperiences/ container and gadgets to demonstrate how one might support the feature.
>
> A spec update will be written up to account for these changes.
>
>
> This addresses bug SHINDIG-1671.
> https://issues.apache.org/jira/browse/SHINDIG-1671
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/EEContainer.js 1211472
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/PhotoList.xml 1211472
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements-container.js 1211478
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/open-views/viewEnhancements-test.js 1211472
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements.js 1211472
>
> Diff: https://reviews.apache.org/r/3053/diff
>
>
> Testing
> -------
>
> all tests pass, added a jsunit test case.
>
>
> Thanks,
>
> Dan
>
>
Re: Review Request: Update Open View APIs To Support Opening Of Views At
Specific Locations
Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3053/#review3718
-----------------------------------------------------------
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/EEContainer.js
<https://reviews.apache.org/r/3053/#comment8347>
I thought we were going to allot this for floats and dialogs?
- Ryan
On 2011-12-07 16:53:27, Dan Dumont wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3053/
> -----------------------------------------------------------
>
> (Updated 2011-12-07 16:53:27)
>
>
> Review request for shindig, Ryan Baxter, Jason Chiang, and Stanton Sievers.
>
>
> Summary
> -------
>
> Also updated the /samplecontainer/examples/embeddedexperiences/ container and gadgets to demonstrate how one might support the feature.
>
> A spec update will be written up to account for these changes.
>
>
> This addresses bug SHINDIG-1671.
> https://issues.apache.org/jira/browse/SHINDIG-1671
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/EEContainer.js 1211472
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/PhotoList.xml 1211472
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements-container.js 1211478
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/open-views/viewEnhancements-test.js 1211472
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements.js 1211472
>
> Diff: https://reviews.apache.org/r/3053/diff
>
>
> Testing
> -------
>
> all tests pass, added a jsunit test case.
>
>
> Thanks,
>
> Dan
>
>
Re: Review Request: Update Open View APIs To Support Opening Of Views At
Specific Locations
Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3053/#review3747
-----------------------------------------------------------
Ship it!
LGTM
- Ryan
On 2011-12-07 16:53:27, Dan Dumont wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3053/
> -----------------------------------------------------------
>
> (Updated 2011-12-07 16:53:27)
>
>
> Review request for shindig, Ryan Baxter, Jason Chiang, and Stanton Sievers.
>
>
> Summary
> -------
>
> Also updated the /samplecontainer/examples/embeddedexperiences/ container and gadgets to demonstrate how one might support the feature.
>
> A spec update will be written up to account for these changes.
>
>
> This addresses bug SHINDIG-1671.
> https://issues.apache.org/jira/browse/SHINDIG-1671
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/EEContainer.js 1211472
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/PhotoList.xml 1211472
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements-container.js 1211478
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/open-views/viewEnhancements-test.js 1211472
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements.js 1211472
>
> Diff: https://reviews.apache.org/r/3053/diff
>
>
> Testing
> -------
>
> all tests pass, added a jsunit test case.
>
>
> Thanks,
>
> Dan
>
>
Re: Review Request: Update Open View APIs To Support Opening Of Views At
Specific Locations
Posted by Stanton Sievers <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3053/#review3861
-----------------------------------------------------------
Ship it!
Looks good to me.
- Stanton
On 2011-12-07 16:53:27, Dan Dumont wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3053/
> -----------------------------------------------------------
>
> (Updated 2011-12-07 16:53:27)
>
>
> Review request for shindig, Ryan Baxter, Jason Chiang, and Stanton Sievers.
>
>
> Summary
> -------
>
> Also updated the /samplecontainer/examples/embeddedexperiences/ container and gadgets to demonstrate how one might support the feature.
>
> A spec update will be written up to account for these changes.
>
>
> This addresses bug SHINDIG-1671.
> https://issues.apache.org/jira/browse/SHINDIG-1671
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/EEContainer.js 1211472
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/PhotoList.xml 1211472
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements-container.js 1211478
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/open-views/viewEnhancements-test.js 1211472
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements.js 1211472
>
> Diff: https://reviews.apache.org/r/3053/diff
>
>
> Testing
> -------
>
> all tests pass, added a jsunit test case.
>
>
> Thanks,
>
> Dan
>
>
Re: Review Request: Update Open View APIs To Support Opening Of Views At
Specific Locations
Posted by Dan Dumont <dd...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3053/#review3937
-----------------------------------------------------------
Ship it!
Committed r1215011
- Dan
On 2011-12-16 00:39:18, Dan Dumont wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3053/
> -----------------------------------------------------------
>
> (Updated 2011-12-16 00:39:18)
>
>
> Review request for shindig, Ryan Baxter, Jason Chiang, and Stanton Sievers.
>
>
> Summary
> -------
>
> Also updated the /samplecontainer/examples/embeddedexperiences/ container and gadgets to demonstrate how one might support the feature.
>
> A spec update will be written up to account for these changes.
>
>
> This addresses bug SHINDIG-1671.
> https://issues.apache.org/jira/browse/SHINDIG-1671
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/EEContainer.js 1214913
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/PhotoList.xml 1214913
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements-container.js 1214913
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements.js 1214913
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/open-views/viewEnhancements-test.js 1214913
>
> Diff: https://reviews.apache.org/r/3053/diff
>
>
> Testing
> -------
>
> all tests pass, added a jsunit test case.
>
>
> Thanks,
>
> Dan
>
>
Re: Review Request: Update Open View APIs To Support Opening Of Views At
Specific Locations
Posted by Dan Dumont <dd...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3053/
-----------------------------------------------------------
(Updated 2011-12-16 00:39:18.474507)
Review request for shindig, Ryan Baxter, Jason Chiang, and Stanton Sievers.
Changes
-------
updated patch for shindig changes since originally posted
Summary
-------
Also updated the /samplecontainer/examples/embeddedexperiences/ container and gadgets to demonstrate how one might support the feature.
A spec update will be written up to account for these changes.
This addresses bug SHINDIG-1671.
https://issues.apache.org/jira/browse/SHINDIG-1671
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/EEContainer.js 1214913
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/PhotoList.xml 1214913
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements-container.js 1214913
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements.js 1214913
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/open-views/viewEnhancements-test.js 1214913
Diff: https://reviews.apache.org/r/3053/diff
Testing
-------
all tests pass, added a jsunit test case.
Thanks,
Dan
Re: Review Request: Update Open View APIs To Support Opening Of Views At
Specific Locations
Posted by Dan Dumont <dd...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3053/#review3740
-----------------------------------------------------------
Spec change: http://code.google.com/p/opensocial-resources/issues/detail?id=1231
- Dan
On 2011-12-07 16:53:27, Dan Dumont wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3053/
> -----------------------------------------------------------
>
> (Updated 2011-12-07 16:53:27)
>
>
> Review request for shindig, Ryan Baxter, Jason Chiang, and Stanton Sievers.
>
>
> Summary
> -------
>
> Also updated the /samplecontainer/examples/embeddedexperiences/ container and gadgets to demonstrate how one might support the feature.
>
> A spec update will be written up to account for these changes.
>
>
> This addresses bug SHINDIG-1671.
> https://issues.apache.org/jira/browse/SHINDIG-1671
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/EEContainer.js 1211472
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/PhotoList.xml 1211472
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements-container.js 1211478
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/open-views/viewEnhancements-test.js 1211472
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements.js 1211472
>
> Diff: https://reviews.apache.org/r/3053/diff
>
>
> Testing
> -------
>
> all tests pass, added a jsunit test case.
>
>
> Thanks,
>
> Dan
>
>
Re: Review Request: Update Open View APIs To Support Opening Of Views At
Specific Locations
Posted by Dan Dumont <dd...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3053/
-----------------------------------------------------------
(Updated 2011-12-07 16:53:27.609819)
Review request for shindig, Ryan Baxter, Jason Chiang, and Stanton Sievers.
Changes
-------
Adding jira
Summary
-------
Also updated the /samplecontainer/examples/embeddedexperiences/ container and gadgets to demonstrate how one might support the feature.
A spec update will be written up to account for these changes.
This addresses bug SHINDIG-1671.
https://issues.apache.org/jira/browse/SHINDIG-1671
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/EEContainer.js 1211472
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/PhotoList.xml 1211472
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements-container.js 1211478
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/open-views/viewEnhancements-test.js 1211472
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements.js 1211472
Diff: https://reviews.apache.org/r/3053/diff
Testing
-------
all tests pass, added a jsunit test case.
Thanks,
Dan