You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2014/11/08 13:33:34 UTC
[jira] [Commented] (COUCHDB-1432) [PULL REQUEST] Fix the benchmark
script ./test/bench/run so it runs
[ https://issues.apache.org/jira/browse/COUCHDB-1432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14203412#comment-14203412 ]
ASF GitHub Bot commented on COUCHDB-1432:
-----------------------------------------
GitHub user robertkowalski opened a pull request:
https://github.com/apache/couchdb/pull/279
Remove broken benchmarks
While I tried to land COUCHDB-1432 it turned out that
/benches/run is broken in several places for a longer time and
nobody noticed: When trying to fix it (adding a file called
test_setup.js) to the template, we will get the next error.
As nobody noticed that it is broken for a longer time it seems we
currently have no need for benchmarks, and if we have that need,
we should add new ones which reflect our current needs and are
compatible with 2.0 too.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robertkowalski/couchdb 1.x.x--broken-bench
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb/pull/279.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #279
----
commit b93bbc573502316d643ad24de0b61365713e4692
Author: Robert Kowalski <ro...@kowalski.gd>
Date: 2014-11-08T12:30:11Z
Remove broken benchmarks
While I tried to land COUCHDB-1432 it turned out that
/benches/run is broken in several places for a longer time and
nobody noticed: When trying to fix it (adding a file called
test_setup.js) to the template, we will get the next error.
As nobody noticed that it is broken for a longer time it seems we
currently have no need for benchmarks, and if we have that need,
we should add new ones which reflect our current needs and are
compatible with 2.0 too.
----
> [PULL REQUEST] Fix the benchmark script ./test/bench/run so it runs
> -------------------------------------------------------------------
>
> Key: COUCHDB-1432
> URL: https://issues.apache.org/jira/browse/COUCHDB-1432
> Project: CouchDB
> Issue Type: Bug
> Components: Build System
> Reporter: Adam Lofts
> Assignee: Robert Kowalski
> Priority: Minor
>
> Please pull from: https://github.com/adamlofts/couchdb/tree/benchmark
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)