You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/11/10 08:48:06 UTC

[GitHub] [flink] zentol opened a new pull request, #21283: [FLINK-29972][docs] Use Elasticsearch 3.0.0 docs

zentol opened a new pull request, #21283:
URL: https://github.com/apache/flink/pull/21283

   Based on #21282.
   
   Switches the docs away from main to `v3.0.0`. Also adds some docs for previous changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] MartijnVisser commented on a diff in pull request #21283: [FLINK-29972][docs] Use Elasticsearch 3.0.0 docs

Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on code in PR #21283:
URL: https://github.com/apache/flink/pull/21283#discussion_r1018951438


##########
docs/setup_docs.sh:
##########
@@ -53,7 +53,7 @@ cd tmp
 
 # Since there's no documentation yet available for a release branch,
 # we only get the documentation from the main branch
-integrate_connector_docs elasticsearch main
+integrate_connector_docs elasticsearch v3.0.0

Review Comment:
   I think that it's best to point that the docs in master point to a version that doesn't exist. But perhaps we should do the same as we do right now, basically say "Only available for stable releases" ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol commented on a diff in pull request #21283: [FLINK-29972][docs] Use Elasticsearch 3.0.0 docs

Posted by GitBox <gi...@apache.org>.
zentol commented on code in PR #21283:
URL: https://github.com/apache/flink/pull/21283#discussion_r1018961980


##########
docs/setup_docs.sh:
##########
@@ -53,7 +53,7 @@ cd tmp
 
 # Since there's no documentation yet available for a release branch,
 # we only get the documentation from the main branch
-integrate_connector_docs elasticsearch main
+integrate_connector_docs elasticsearch v3.0.0

Review Comment:
   https://issues.apache.org/jira/browse/FLINK-29979



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol commented on a diff in pull request #21283: [FLINK-29972][docs] Use Elasticsearch 3.0.0 docs

Posted by GitBox <gi...@apache.org>.
zentol commented on code in PR #21283:
URL: https://github.com/apache/flink/pull/21283#discussion_r1018948785


##########
docs/setup_docs.sh:
##########
@@ -53,7 +53,7 @@ cd tmp
 
 # Since there's no documentation yet available for a release branch,
 # we only get the documentation from the main branch
-integrate_connector_docs elasticsearch main
+integrate_connector_docs elasticsearch v3.0.0

Review Comment:
   so maybe we should hack some `TBD` special case into the connector_artifact shortcode



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol commented on a diff in pull request #21283: [FLINK-29972][docs] Use Elasticsearch 3.0.0 docs

Posted by GitBox <gi...@apache.org>.
zentol commented on code in PR #21283:
URL: https://github.com/apache/flink/pull/21283#discussion_r1018947920


##########
docs/setup_docs.sh:
##########
@@ -53,7 +53,7 @@ cd tmp
 
 # Since there's no documentation yet available for a release branch,
 # we only get the documentation from the main branch
-integrate_connector_docs elasticsearch main
+integrate_connector_docs elasticsearch v3.0.0

Review Comment:
   We'll actually need to think a bit how this will play out for 1.17.0. There will de-facto be no released connector version that we can refer to.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol merged pull request #21283: [FLINK-29972][docs] Use Elasticsearch 3.0.0 docs

Posted by GitBox <gi...@apache.org>.
zentol merged PR #21283:
URL: https://github.com/apache/flink/pull/21283


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol commented on a diff in pull request #21283: [FLINK-29972][docs] Use Elasticsearch 3.0.0 docs

Posted by GitBox <gi...@apache.org>.
zentol commented on code in PR #21283:
URL: https://github.com/apache/flink/pull/21283#discussion_r1018947920


##########
docs/setup_docs.sh:
##########
@@ -53,7 +53,7 @@ cd tmp
 
 # Since there's no documentation yet available for a release branch,
 # we only get the documentation from the main branch
-integrate_connector_docs elasticsearch main
+integrate_connector_docs elasticsearch v3.0.0

Review Comment:
   We'll actually need to think a bit how this will play out for 1.17.0. There will de-facto be no released connector version that they can refer to.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #21283: [FLINK-29972][docs] Use Elasticsearch 3.0.0 docs

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #21283:
URL: https://github.com/apache/flink/pull/21283#issuecomment-1309962917

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "43380cf32d231f7ef623b818cc380d8e18621b3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "43380cf32d231f7ef623b818cc380d8e18621b3c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 43380cf32d231f7ef623b818cc380d8e18621b3c UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] MartijnVisser commented on a diff in pull request #21283: [FLINK-29972][docs] Use Elasticsearch 3.0.0 docs

Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on code in PR #21283:
URL: https://github.com/apache/flink/pull/21283#discussion_r1018905706


##########
docs/setup_docs.sh:
##########
@@ -53,7 +53,7 @@ cd tmp
 
 # Since there's no documentation yet available for a release branch,
 # we only get the documentation from the main branch
-integrate_connector_docs elasticsearch main
+integrate_connector_docs elasticsearch v3.0.0

Review Comment:
   Do we want to integrate the 3.0.0 release with Flink SNAPSHOTS? Or should Flink's `master` point to the Elasticsearch `main` branch while Flink's `release-1.16` points to Elasticsearch's `3.0.0` ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol commented on a diff in pull request #21283: [FLINK-29972][docs] Use Elasticsearch 3.0.0 docs

Posted by GitBox <gi...@apache.org>.
zentol commented on code in PR #21283:
URL: https://github.com/apache/flink/pull/21283#discussion_r1018937434


##########
docs/setup_docs.sh:
##########
@@ -53,7 +53,7 @@ cd tmp
 
 # Since there's no documentation yet available for a release branch,
 # we only get the documentation from the main branch
-integrate_connector_docs elasticsearch main
+integrate_connector_docs elasticsearch v3.0.0

Review Comment:
   although it would be better if 1.17 referred to 3.0.0 by default instead of `main`
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol commented on a diff in pull request #21283: [FLINK-29972][docs] Use Elasticsearch 3.0.0 docs

Posted by GitBox <gi...@apache.org>.
zentol commented on code in PR #21283:
URL: https://github.com/apache/flink/pull/21283#discussion_r1018936922


##########
docs/setup_docs.sh:
##########
@@ -53,7 +53,7 @@ cd tmp
 
 # Since there's no documentation yet available for a release branch,
 # we only get the documentation from the main branch
-integrate_connector_docs elasticsearch main
+integrate_connector_docs elasticsearch v3.0.0

Review Comment:
   I'm not sure actually. Either way the version in the master docs will not actually exist.
   
   I'd be fine with only making this change in 1.16



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org