[jira] [Commented] (TS-2202) remove manager error and fatal useless errno and error message

["Yunkai Zhang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TS-2202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13770514#comment-13770514 ] 

Yunkai Zhang commented on TS-2202:
----------------------------------

This solution will change the interface of mgmt_elog()/mgmt_fatal() from:
{code}
void mgmt_elog(FILE * log, const char *message_format, ...);
{code}

to:
{code}
void mgmt_elog(FILE * log, const int lerrno, const char *message_format, ...);
{code}

I would suggest don't break the interface, for two reason:
1) Don't bother user as much as possible. The new interface will force user pass *errno* in everywhere.

2) We want to replace mgmt log with Diags API in the future, keep these interfaces compatible with Diags as it was can make it easy to be replaced.
                
> remove manager error and fatal useless errno and error message
> --------------------------------------------------------------
>
>                 Key: TS-2202
>                 URL: https://issues.apache.org/jira/browse/TS-2202
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Management
>            Reporter: Yu Qing
>            Assignee: Yu Qing
>         Attachments: 0001-TS-2202-remove-manager-error-and-fatal-useless-error.patch
>
>
> we should log errno and strerror(errno) only when errno != 0.
> the errno parameter should pass by the caller.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira