You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by el...@apache.org on 2017/08/25 23:14:48 UTC
[1/7] hbase git commit: HBASE-18679 Add a null check around the
result of getCounters() in ITBLL
Repository: hbase
Updated Branches:
refs/heads/branch-1 50c67e969 -> fd4387998
refs/heads/branch-1.1 43b0a6612 -> 8d6e37bb2
refs/heads/branch-1.2 134763530 -> 5c6fb74b5
refs/heads/branch-1.3 22e8f87ae -> 4ce79774a
refs/heads/branch-1.4 ca6714d54 -> a02521929
refs/heads/branch-2 005693f0c -> b55b952d5
refs/heads/master 439191ece -> 2773510f1
HBASE-18679 Add a null check around the result of getCounters() in ITBLL
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/2773510f
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/2773510f
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/2773510f
Branch: refs/heads/master
Commit: 2773510f120730f926569fef30c3e7b766517e89
Parents: 439191e
Author: Josh Elser <el...@apache.org>
Authored: Thu Aug 24 17:52:13 2017 -0400
Committer: Josh Elser <el...@apache.org>
Committed: Fri Aug 25 18:40:02 2017 -0400
----------------------------------------------------------------------
.../hbase/test/IntegrationTestBigLinkedList.java | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hbase/blob/2773510f/hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestBigLinkedList.java
----------------------------------------------------------------------
diff --git a/hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestBigLinkedList.java b/hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestBigLinkedList.java
index 2fdfab6..f05ef66 100644
--- a/hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestBigLinkedList.java
+++ b/hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestBigLinkedList.java
@@ -820,6 +820,11 @@ public class IntegrationTestBigLinkedList extends IntegrationTestBase {
public boolean verify() {
try {
Counters counters = job.getCounters();
+ if (counters == null) {
+ LOG.info("Counters object was null, Generator verification cannot be performed."
+ + " This is commonly a result of insufficient YARN configuration.");
+ return false;
+ }
if (counters.findCounter(Counts.TERMINATING).getValue() > 0 ||
counters.findCounter(Counts.UNDEFINED).getValue() > 0 ||
@@ -1315,7 +1320,8 @@ public class IntegrationTestBigLinkedList extends IntegrationTestBase {
if (success) {
Counters counters = job.getCounters();
if (null == counters) {
- LOG.warn("Counters were null, cannot verify Job completion");
+ LOG.warn("Counters were null, cannot verify Job completion."
+ + " This is commonly a result of insufficient YARN configuration.");
// We don't have access to the counters to know if we have "bad" counts
return 0;
}
@@ -1337,6 +1343,11 @@ public class IntegrationTestBigLinkedList extends IntegrationTestBase {
}
Counters counters = job.getCounters();
+ if (counters == null) {
+ LOG.info("Counters object was null, write verification cannot be performed."
+ + " This is commonly a result of insufficient YARN configuration.");
+ return false;
+ }
// Run through each check, even if we fail one early
boolean success = verifyExpectedValues(expectedReferenced, counters);
[3/7] hbase git commit: HBASE-18679 Add a null check around the
result of getCounters() in ITBLL
Posted by el...@apache.org.
HBASE-18679 Add a null check around the result of getCounters() in ITBLL
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/fd438799
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/fd438799
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/fd438799
Branch: refs/heads/branch-1
Commit: fd43879985547eb05e04bed4c91feea7eac977c3
Parents: 50c67e9
Author: Josh Elser <el...@apache.org>
Authored: Thu Aug 24 17:52:13 2017 -0400
Committer: Josh Elser <el...@apache.org>
Committed: Fri Aug 25 18:54:01 2017 -0400
----------------------------------------------------------------------
.../hbase/test/IntegrationTestBigLinkedList.java | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hbase/blob/fd438799/hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestBigLinkedList.java
----------------------------------------------------------------------
diff --git a/hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestBigLinkedList.java b/hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestBigLinkedList.java
index 4ab0a58..0e3b198 100644
--- a/hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestBigLinkedList.java
+++ b/hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestBigLinkedList.java
@@ -815,6 +815,11 @@ public class IntegrationTestBigLinkedList extends IntegrationTestBase {
public boolean verify() {
try {
Counters counters = job.getCounters();
+ if (counters == null) {
+ LOG.info("Counters object was null, Generator verification cannot be performed."
+ + " This is commonly a result of insufficient YARN configuration.");
+ return false;
+ }
if (counters.findCounter(Counts.TERMINATING).getValue() > 0 ||
counters.findCounter(Counts.UNDEFINED).getValue() > 0 ||
@@ -1306,7 +1311,8 @@ public class IntegrationTestBigLinkedList extends IntegrationTestBase {
if (success) {
Counters counters = job.getCounters();
if (null == counters) {
- LOG.warn("Counters were null, cannot verify Job completion");
+ LOG.warn("Counters were null, cannot verify Job completion."
+ + " This is commonly a result of insufficient YARN configuration.");
// We don't have access to the counters to know if we have "bad" counts
return 0;
}
@@ -1328,6 +1334,11 @@ public class IntegrationTestBigLinkedList extends IntegrationTestBase {
}
Counters counters = job.getCounters();
+ if (counters == null) {
+ LOG.info("Counters object was null, write verification cannot be performed."
+ + " This is commonly a result of insufficient YARN configuration.");
+ return false;
+ }
// Run through each check, even if we fail one early
boolean success = verifyExpectedValues(expectedReferenced, counters);
[2/7] hbase git commit: HBASE-18679 Add a null check around the
result of getCounters() in ITBLL
Posted by el...@apache.org.
HBASE-18679 Add a null check around the result of getCounters() in ITBLL
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/b55b952d
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/b55b952d
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/b55b952d
Branch: refs/heads/branch-2
Commit: b55b952d5c5e90bde03f454500e867b7909fea75
Parents: 005693f
Author: Josh Elser <el...@apache.org>
Authored: Thu Aug 24 17:52:13 2017 -0400
Committer: Josh Elser <el...@apache.org>
Committed: Fri Aug 25 18:45:12 2017 -0400
----------------------------------------------------------------------
.../hbase/test/IntegrationTestBigLinkedList.java | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hbase/blob/b55b952d/hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestBigLinkedList.java
----------------------------------------------------------------------
diff --git a/hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestBigLinkedList.java b/hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestBigLinkedList.java
index 2fdfab6..f05ef66 100644
--- a/hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestBigLinkedList.java
+++ b/hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestBigLinkedList.java
@@ -820,6 +820,11 @@ public class IntegrationTestBigLinkedList extends IntegrationTestBase {
public boolean verify() {
try {
Counters counters = job.getCounters();
+ if (counters == null) {
+ LOG.info("Counters object was null, Generator verification cannot be performed."
+ + " This is commonly a result of insufficient YARN configuration.");
+ return false;
+ }
if (counters.findCounter(Counts.TERMINATING).getValue() > 0 ||
counters.findCounter(Counts.UNDEFINED).getValue() > 0 ||
@@ -1315,7 +1320,8 @@ public class IntegrationTestBigLinkedList extends IntegrationTestBase {
if (success) {
Counters counters = job.getCounters();
if (null == counters) {
- LOG.warn("Counters were null, cannot verify Job completion");
+ LOG.warn("Counters were null, cannot verify Job completion."
+ + " This is commonly a result of insufficient YARN configuration.");
// We don't have access to the counters to know if we have "bad" counts
return 0;
}
@@ -1337,6 +1343,11 @@ public class IntegrationTestBigLinkedList extends IntegrationTestBase {
}
Counters counters = job.getCounters();
+ if (counters == null) {
+ LOG.info("Counters object was null, write verification cannot be performed."
+ + " This is commonly a result of insufficient YARN configuration.");
+ return false;
+ }
// Run through each check, even if we fail one early
boolean success = verifyExpectedValues(expectedReferenced, counters);
[5/7] hbase git commit: HBASE-18679 Add a null check around the
result of getCounters() in ITBLL
Posted by el...@apache.org.
HBASE-18679 Add a null check around the result of getCounters() in ITBLL
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/4ce79774
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/4ce79774
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/4ce79774
Branch: refs/heads/branch-1.3
Commit: 4ce79774a13450f8a2f44cc3c4e437371d80f0fb
Parents: 22e8f87
Author: Josh Elser <el...@apache.org>
Authored: Thu Aug 24 17:52:13 2017 -0400
Committer: Josh Elser <el...@apache.org>
Committed: Fri Aug 25 19:05:46 2017 -0400
----------------------------------------------------------------------
.../hbase/test/IntegrationTestBigLinkedList.java | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hbase/blob/4ce79774/hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestBigLinkedList.java
----------------------------------------------------------------------
diff --git a/hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestBigLinkedList.java b/hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestBigLinkedList.java
index 4ab0a58..0e3b198 100644
--- a/hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestBigLinkedList.java
+++ b/hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestBigLinkedList.java
@@ -815,6 +815,11 @@ public class IntegrationTestBigLinkedList extends IntegrationTestBase {
public boolean verify() {
try {
Counters counters = job.getCounters();
+ if (counters == null) {
+ LOG.info("Counters object was null, Generator verification cannot be performed."
+ + " This is commonly a result of insufficient YARN configuration.");
+ return false;
+ }
if (counters.findCounter(Counts.TERMINATING).getValue() > 0 ||
counters.findCounter(Counts.UNDEFINED).getValue() > 0 ||
@@ -1306,7 +1311,8 @@ public class IntegrationTestBigLinkedList extends IntegrationTestBase {
if (success) {
Counters counters = job.getCounters();
if (null == counters) {
- LOG.warn("Counters were null, cannot verify Job completion");
+ LOG.warn("Counters were null, cannot verify Job completion."
+ + " This is commonly a result of insufficient YARN configuration.");
// We don't have access to the counters to know if we have "bad" counts
return 0;
}
@@ -1328,6 +1334,11 @@ public class IntegrationTestBigLinkedList extends IntegrationTestBase {
}
Counters counters = job.getCounters();
+ if (counters == null) {
+ LOG.info("Counters object was null, write verification cannot be performed."
+ + " This is commonly a result of insufficient YARN configuration.");
+ return false;
+ }
// Run through each check, even if we fail one early
boolean success = verifyExpectedValues(expectedReferenced, counters);
[6/7] hbase git commit: HBASE-18679 Add a null check around the
result of getCounters() in ITBLL
Posted by el...@apache.org.
HBASE-18679 Add a null check around the result of getCounters() in ITBLL
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/5c6fb74b
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/5c6fb74b
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/5c6fb74b
Branch: refs/heads/branch-1.2
Commit: 5c6fb74b5fd835ea20ba984cd63749d0d1c70630
Parents: 1347635
Author: Josh Elser <el...@apache.org>
Authored: Thu Aug 24 17:52:13 2017 -0400
Committer: Josh Elser <el...@apache.org>
Committed: Fri Aug 25 19:09:00 2017 -0400
----------------------------------------------------------------------
.../hadoop/hbase/test/IntegrationTestBigLinkedList.java | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hbase/blob/5c6fb74b/hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestBigLinkedList.java
----------------------------------------------------------------------
diff --git a/hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestBigLinkedList.java b/hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestBigLinkedList.java
index 91f99f1..45b0d03 100644
--- a/hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestBigLinkedList.java
+++ b/hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestBigLinkedList.java
@@ -1106,7 +1106,8 @@ public class IntegrationTestBigLinkedList extends IntegrationTestBase {
if (success) {
Counters counters = job.getCounters();
if (null == counters) {
- LOG.warn("Counters were null, cannot verify Job completion");
+ LOG.warn("Counters were null, cannot verify Job completion."
+ + " This is commonly a result of insufficient YARN configuration.");
// We don't have access to the counters to know if we have "bad" counts
return 0;
}
@@ -1128,6 +1129,11 @@ public class IntegrationTestBigLinkedList extends IntegrationTestBase {
}
Counters counters = job.getCounters();
+ if (counters == null) {
+ LOG.info("Counters object was null, write verification cannot be performed."
+ + " This is commonly a result of insufficient YARN configuration.");
+ return false;
+ }
// Run through each check, even if we fail one early
boolean success = verifyExpectedValues(expectedReferenced, counters);
[7/7] hbase git commit: HBASE-18679 Add a null check around the
result of getCounters() in ITBLL
Posted by el...@apache.org.
HBASE-18679 Add a null check around the result of getCounters() in ITBLL
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/8d6e37bb
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/8d6e37bb
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/8d6e37bb
Branch: refs/heads/branch-1.1
Commit: 8d6e37bb260a787e7d5d97495f5cc1ca260695d7
Parents: 43b0a66
Author: Josh Elser <el...@apache.org>
Authored: Thu Aug 24 17:52:13 2017 -0400
Committer: Josh Elser <el...@apache.org>
Committed: Fri Aug 25 19:11:49 2017 -0400
----------------------------------------------------------------------
.../hadoop/hbase/test/IntegrationTestBigLinkedList.java | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hbase/blob/8d6e37bb/hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestBigLinkedList.java
----------------------------------------------------------------------
diff --git a/hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestBigLinkedList.java b/hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestBigLinkedList.java
index 849efa4..7aed9de 100644
--- a/hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestBigLinkedList.java
+++ b/hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestBigLinkedList.java
@@ -1104,7 +1104,8 @@ public class IntegrationTestBigLinkedList extends IntegrationTestBase {
if (success) {
Counters counters = job.getCounters();
if (null == counters) {
- LOG.warn("Counters were null, cannot verify Job completion");
+ LOG.warn("Counters were null, cannot verify Job completion."
+ + " This is commonly a result of insufficient YARN configuration.");
// We don't have access to the counters to know if we have "bad" counts
return 0;
}
@@ -1126,6 +1127,11 @@ public class IntegrationTestBigLinkedList extends IntegrationTestBase {
}
Counters counters = job.getCounters();
+ if (counters == null) {
+ LOG.info("Counters object was null, write verification cannot be performed."
+ + " This is commonly a result of insufficient YARN configuration.");
+ return false;
+ }
// Run through each check, even if we fail one early
boolean success = verifyExpectedValues(expectedReferenced, counters);
[4/7] hbase git commit: HBASE-18679 Add a null check around the
result of getCounters() in ITBLL
Posted by el...@apache.org.
HBASE-18679 Add a null check around the result of getCounters() in ITBLL
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/a0252192
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/a0252192
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/a0252192
Branch: refs/heads/branch-1.4
Commit: a02521929806ff065753418e00292d422350a3e1
Parents: ca6714d
Author: Josh Elser <el...@apache.org>
Authored: Thu Aug 24 17:52:13 2017 -0400
Committer: Josh Elser <el...@apache.org>
Committed: Fri Aug 25 18:59:19 2017 -0400
----------------------------------------------------------------------
.../hbase/test/IntegrationTestBigLinkedList.java | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hbase/blob/a0252192/hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestBigLinkedList.java
----------------------------------------------------------------------
diff --git a/hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestBigLinkedList.java b/hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestBigLinkedList.java
index 4ab0a58..0e3b198 100644
--- a/hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestBigLinkedList.java
+++ b/hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestBigLinkedList.java
@@ -815,6 +815,11 @@ public class IntegrationTestBigLinkedList extends IntegrationTestBase {
public boolean verify() {
try {
Counters counters = job.getCounters();
+ if (counters == null) {
+ LOG.info("Counters object was null, Generator verification cannot be performed."
+ + " This is commonly a result of insufficient YARN configuration.");
+ return false;
+ }
if (counters.findCounter(Counts.TERMINATING).getValue() > 0 ||
counters.findCounter(Counts.UNDEFINED).getValue() > 0 ||
@@ -1306,7 +1311,8 @@ public class IntegrationTestBigLinkedList extends IntegrationTestBase {
if (success) {
Counters counters = job.getCounters();
if (null == counters) {
- LOG.warn("Counters were null, cannot verify Job completion");
+ LOG.warn("Counters were null, cannot verify Job completion."
+ + " This is commonly a result of insufficient YARN configuration.");
// We don't have access to the counters to know if we have "bad" counts
return 0;
}
@@ -1328,6 +1334,11 @@ public class IntegrationTestBigLinkedList extends IntegrationTestBase {
}
Counters counters = job.getCounters();
+ if (counters == null) {
+ LOG.info("Counters object was null, write verification cannot be performed."
+ + " This is commonly a result of insufficient YARN configuration.");
+ return false;
+ }
// Run through each check, even if we fail one early
boolean success = verifyExpectedValues(expectedReferenced, counters);