You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2015/07/14 19:27:33 UTC

Review Request 36478: Client: when waiting for a job update, use helpful exit codes.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36478/
-----------------------------------------------------------

Review request for Aurora and Zameer Manji.


Bugs: AURORA-1399
    https://issues.apache.org/jira/browse/AURORA-1399


Repository: aurora


Description
-------

Client: when waiting for a job update, use helpful exit codes.


Diffs
-----

  src/main/python/apache/aurora/client/cli/update.py 70f6c69aa9226981c66c0f986fd53840c56d210f 
  src/test/python/apache/aurora/client/cli/test_supdate.py c6b6ccc8570bac9c742e6458a9d09e24aa0a3bcc 

Diff: https://reviews.apache.org/r/36478/diff/


Testing
-------


Thanks,

Bill Farner


Re: Review Request 36478: Client: when waiting for a job update, use helpful exit codes.

Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36478/#review91664
-----------------------------------------------------------

Ship it!


Master (5c4c42c) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On July 14, 2015, 8:37 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36478/
> -----------------------------------------------------------
> 
> (Updated July 14, 2015, 8:37 p.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Bugs: AURORA-1399
>     https://issues.apache.org/jira/browse/AURORA-1399
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Client: when waiting for a job update, use helpful exit codes.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/update.py 2dcc8f3c38dc7b9ea3cfe97d6066600a578f75bb 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 2d7d49622592deef7392f2276b7eaebdd5e5e404 
> 
> Diff: https://reviews.apache.org/r/36478/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Re: Review Request 36478: Client: when waiting for a job update, use helpful exit codes.

Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36478/
-----------------------------------------------------------

(Updated July 14, 2015, 8:37 p.m.)


Review request for Aurora and Zameer Manji.


Changes
-------

Rebase.


Bugs: AURORA-1399
    https://issues.apache.org/jira/browse/AURORA-1399


Repository: aurora


Description
-------

Client: when waiting for a job update, use helpful exit codes.


Diffs (updated)
-----

  src/main/python/apache/aurora/client/cli/update.py 2dcc8f3c38dc7b9ea3cfe97d6066600a578f75bb 
  src/test/python/apache/aurora/client/cli/test_supdate.py 2d7d49622592deef7392f2276b7eaebdd5e5e404 

Diff: https://reviews.apache.org/r/36478/diff/


Testing
-------


Thanks,

Bill Farner


Re: Review Request 36478: Client: when waiting for a job update, use helpful exit codes.

Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36478/#review91653
-----------------------------------------------------------

Ship it!


Ship It!

- Zameer Manji


On July 14, 2015, 10:27 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36478/
> -----------------------------------------------------------
> 
> (Updated July 14, 2015, 10:27 a.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Bugs: AURORA-1399
>     https://issues.apache.org/jira/browse/AURORA-1399
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Client: when waiting for a job update, use helpful exit codes.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/update.py 70f6c69aa9226981c66c0f986fd53840c56d210f 
>   src/test/python/apache/aurora/client/cli/test_supdate.py c6b6ccc8570bac9c742e6458a9d09e24aa0a3bcc 
> 
> Diff: https://reviews.apache.org/r/36478/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Re: Review Request 36478: Client: when waiting for a job update, use helpful exit codes.

Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36478/#review91640
-----------------------------------------------------------

Ship it!


Master (1a01a5b) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On July 14, 2015, 5:27 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36478/
> -----------------------------------------------------------
> 
> (Updated July 14, 2015, 5:27 p.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Bugs: AURORA-1399
>     https://issues.apache.org/jira/browse/AURORA-1399
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Client: when waiting for a job update, use helpful exit codes.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/update.py 70f6c69aa9226981c66c0f986fd53840c56d210f 
>   src/test/python/apache/aurora/client/cli/test_supdate.py c6b6ccc8570bac9c742e6458a9d09e24aa0a3bcc 
> 
> Diff: https://reviews.apache.org/r/36478/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>