You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by anoopsharma00 <gi...@git.apache.org> on 2018/06/04 17:37:14 UTC
[GitHub] trafodion pull request #1593: TRAFODION-3086 Traf support for DDL operations...
GitHub user anoopsharma00 opened a pull request:
https://github.com/apache/trafodion/pull/1593
TRAFODION-3086 Traf support for DDL operations on Hive objects
-- Support for TRAFODION-3086. Details in document attached to jira.
Other changes:
-- support for "if not exists", "if exists" clause for create/drop view
-- Support for: truncate T, truncate table T.
-- same as purgedata
-- showddl <tab>, detail
-- unregister hive schema <sch>
-- will unregister all objects in specified schema
-- Support for "if not registered", "if registered" clauss for
register/unregister command.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/anoopsharma00/trafodion ansharma_hiveddl_br
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafodion/pull/1593.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1593
----
commit 6f490daf1b30e6ced48ce43bbd067a0bd828e620
Author: Anoop Sharma <an...@...>
Date: 2018-06-04T17:33:12Z
TRAFODION-3086 Traf support for DDL operations on Hive objects
-- Support for TRAFODION-3086. Details in document attached to jira.
Other changes:
-- support for "if not exists", "if exists" clause for create/drop view
-- Support for: truncate T, truncate table T.
-- same as purgedata
-- showddl <tab>, detail
-- unregister hive schema <sch>
-- will unregister all objects in specified schema
-- Support for "if not registered", "if registered" clauss for
register/unregister command.
----
---
[GitHub] trafodion pull request #1593: TRAFODION-3086 Traf support for DDL operations...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/trafodion/pull/1593
---
[GitHub] trafodion pull request #1593: TRAFODION-3086 Traf support for DDL operations...
Posted by zellerh <gi...@git.apache.org>.
Github user zellerh commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1593#discussion_r193218463
--- Diff: core/sqf/sql/scripts/install_local_hadoop ---
@@ -726,21 +726,27 @@ else
if [ $? -ne 0 ]; then
(${JAVA_EXE} -version 2>&1) | grep '1.7' >/dev/null
if [ $? -ne 0 ]; then
- echo '**** ERROR:'
- cat <<EOF
- Please make sure you are using the Java 1.6 or 1.7 SDK.
- Otherwise, download it into ${MY_SW_ROOT}, extract it and
- make a symbolic link ${MY_SW_ROOT}/java that points to it and
- export JAVA_HOME=${MY_SW_ROOT}/java
+ (${JAVA_EXE} -version 2>&1) | grep '1.8' >/dev/null
+ if [ $? -ne 0 ]; then
+ echo '**** ERROR:'
+ cat <<EOF
+ Please make sure you are using the Java 1.6 or 1.7 SDK.
--- End diff --
Minor comment: This should say 1.7 or 1.8 SDK.
---