You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@ratis.apache.org by GitBox <gi...@apache.org> on 2023/01/18 02:34:04 UTC

[GitHub] [ratis] kaijchen commented on a diff in pull request #807: RATIS-1762. Support transfer leadership between nodes with same priority

kaijchen commented on code in PR #807:
URL: https://github.com/apache/ratis/pull/807#discussion_r1073034716


##########
ratis-server/src/main/java/org/apache/ratis/server/impl/LeaderStateImpl.java:
##########
@@ -1167,6 +1180,75 @@ public void onAppendEntriesReply(LogAppender appender, RaftProtos.AppendEntriesR
     readIndexHeartbeats.onAppendEntriesReply(appender, reply, this::hasMajority);
   }
 
+  @Override
+  public void onTransferLeadership(RaftPeerId transferee) {

Review Comment:
   The current `LeaderState#sendStartLeaderElectionToHigherPriorityPeer()` is actually `sendTimeoutNow()`.
   However, I think it should be refactored in another PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org