You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@geode.apache.org by kirklund <gi...@git.apache.org> on 2016/12/08 22:46:02 UTC

[GitHub] geode pull request #307: GEODE-1027: add unit test for previously committed ...

GitHub user kirklund opened a pull request:

    https://github.com/apache/geode/pull/307

    GEODE-1027: add unit test for previously committed fix

    * create new unit tests for MBeanStatsMonitor to test previously committed fix for GEODE-1027
    * remove unnecessary final modifier from class and methods in StatisticsMonitor and ValueMonitor
    * update logging in MBeanStatsMonitor
    * change couple methods in SampleCollector from public to package
    * clean up StatisticsMonitor
    * clean up ValueMonitor
    * clean up MBeanStatsMonitor


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kirklund/geode feature/GEODE-1027

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/307.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #307
    
----
commit 65e5450ccc3556774589867627c19cc2842f0fa5
Author: Kirk Lund <kl...@apache.org>
Date:   2016-12-07T23:33:51Z

    GEODE-1027: add unit test for previously committed fix

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #307: GEODE-1027: add unit test for previously committed fix

Posted by kirklund <gi...@git.apache.org>.

Github user kirklund commented on the issue:

    https://github.com/apache/geode/pull/307
  
    This was merged in but I forgot to add "This closes #307"
    
    commit 1f49cbcc8cbaad5c0c2ccb8063a67bd6bb88a9b9
    Author: Kirk Lund <kl...@apache.org>
    Date:   Wed Dec 7 15:33:51 2016 -0800
    
        GEODE-1027: add unit test for previously committed fix


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #307: GEODE-1027: add unit test for previously committed fix

Posted by jaredjstewart <gi...@git.apache.org>.

Github user jaredjstewart commented on the issue:

    https://github.com/apache/geode/pull/307
  
    +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #307: GEODE-1027: add unit test for previously committed fix

Posted by jinmeiliao <gi...@git.apache.org>.

Github user jinmeiliao commented on the issue:

    https://github.com/apache/geode/pull/307
  
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #307: GEODE-1027: add unit test for previously committed ...

Posted by kirklund <gi...@git.apache.org>.

Github user kirklund closed the pull request at:

    https://github.com/apache/geode/pull/307


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---