You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/06/23 13:19:53 UTC
[GitHub] [doris] mrhhsg commented on a diff in pull request #10370: [improvement]Support vectorized predicates for dict columns
mrhhsg commented on code in PR #10370:
URL: https://github.com/apache/doris/pull/10370#discussion_r905013078
##########
be/src/olap/comparison_predicate.cpp:
##########
@@ -251,8 +249,28 @@ COMPARISON_PRED_COLUMN_EVALUATE(GreaterEqualPredicate, >=, true)
flags[i] = (data_array_uint32_t[i] OP int32_val) && (!null_bitmap[i]); \
} \
} else { \
- for (uint16_t i = 0; i < size; i++) { \
- flags[i] = (data_array[i] OP _value) && (!null_bitmap[i]); \
+ if (nested_col.is_column_dictionary()) { \
+ if constexpr (IS_RANGE) column.convert_dict_codes_if_necessary(); \
+ if constexpr (std::is_same_v<T, StringValue>) { \
Review Comment:
To avoid compiling with other types.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org