You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "DomGarguilo (via GitHub)" <gi...@apache.org> on 2025/05/29 19:52:31 UTC

[PR] Update Javadoc for wrapped TableNotFoundException in modifyProperties and removeConstraint [accumulo]

DomGarguilo opened a new pull request, #5595:
URL: https://github.com/apache/accumulo/pull/5595

   This PR adds a note to `modifyProperties()` and `removeConstraint()` documenting that they wrap TableNotFoundException in AccumuloException.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Update Javadoc for wrapped TableNotFoundException in modifyProperties and removeConstraint [accumulo]

Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion commented on PR #5595:
URL: https://github.com/apache/accumulo/pull/5595#issuecomment-2922377649

   I have to assume that the wrapping was done for some API stability reason. I agree that we should fix for 4.0. It looks like the Exceptions that we have on the client side (TableNotFoundException for example) don't extend AccumuloException. Changing the Exception hierarchy with the client side exceptions should allow us to throw without wrapping and just declare AccumuloException in the API.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Update Javadoc for wrapped TableNotFoundException in modifyProperties and removeConstraint [accumulo]

Posted by "DomGarguilo (via GitHub)" <gi...@apache.org>.
DomGarguilo commented on PR #5595:
URL: https://github.com/apache/accumulo/pull/5595#issuecomment-2920430202

   I am not sure why some methods wrap TableNotFoundException and others just throw it directly. To me it seems like it would be better to just throw it directly but I assume there was a reason why things are done this way.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Update Javadoc for wrapped TableNotFoundException in modifyProperties and removeConstraint [accumulo]

Posted by "DomGarguilo (via GitHub)" <gi...@apache.org>.
DomGarguilo merged PR #5595:
URL: https://github.com/apache/accumulo/pull/5595


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org