You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Mona Chitnis <mo...@yahoo.in> on 2013/05/21 06:09:29 UTC
Review Request: OOZIE-1375 Generate Job notification events for Workflow
Actions
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11295/
-----------------------------------------------------------
Review request for oozie.
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1375
Note:
1. The SignalXCommand part of the patch will be rebased after the bug-fix for duplicate wf_job event generation
2. Looking for better solution than not changing method handleNonTransient from protected to public (visibleForTesting does not work outside packages)
This addresses bug OOZIE-1375.
https://issues.apache.org/jira/browse/OOZIE-1375
Diffs
-----
trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java 1484558
trunk/core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java 1484558
trunk/core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java 1484558
trunk/core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 1484558
trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 1484558
trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java 1484558
trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java 1484558
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionGetJPAExecutor.java 1484558
trunk/core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java 1484558
trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1484558
Diff: https://reviews.apache.org/r/11295/diff/
Testing
-------
Testcase added. Other test files including XTestCase edited to enhance utility method createWfAction() to accept pending flag
Thanks,
Mona Chitnis
Re: Review Request: OOZIE-1375 Generate Job notification events for Workflow
Actions
Posted by Virag Kothari <vi...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11295/#review21196
-----------------------------------------------------------
+1 after addressing one last comment
trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java
<https://reviews.apache.org/r/11295/#comment44023>
USER_RETRY should be ignored here as events are not generated for that state
- Virag Kothari
On May 30, 2013, 1:48 a.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11295/
> -----------------------------------------------------------
>
> (Updated May 30, 2013, 1:48 a.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1375
>
>
> This addresses bug OOZIE-1375.
> https://issues.apache.org/jira/browse/OOZIE-1375
>
>
> Diffs
> -----
>
> trunk/client/src/main/java/org/apache/oozie/client/event/jms/MessageDeserializer.java 1487638
> trunk/client/src/main/java/org/apache/oozie/client/event/message/WorkflowActionMessage.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java 1487638
> trunk/core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java 1487638
> trunk/core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java 1487638
> trunk/core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java 1487638
> trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 1487638
> trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 1487638
> trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java 1487638
> trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java 1487638
> trunk/core/src/main/java/org/apache/oozie/event/messaging/MessageFactory.java 1487638
> trunk/core/src/main/java/org/apache/oozie/jms/JMSJobEventListener.java 1487638
> trunk/core/src/main/resources/oozie-default.xml 1487638
> trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java 1487638
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionGetJPAExecutor.java 1487638
> trunk/core/src/test/java/org/apache/oozie/jms/TestJMSJobEventListener.java 1487638
> trunk/core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java 1487638
> trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1487638
>
> Diff: https://reviews.apache.org/r/11295/diff/
>
>
> Testing
> -------
>
> Testcase added. Other test files including XTestCase edited to enhance utility method createWfAction() to accept pending flag
>
>
> Thanks,
>
> Mona Chitnis
>
>
Re: Review Request: OOZIE-1375 Generate Job notification events for Workflow
Actions
Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11295/
-----------------------------------------------------------
(Updated June 5, 2013, 12:37 a.m.)
Review request for oozie.
Changes
-------
1. Removed JMS Message creation for wf-action events and also removed from default app.types.
2. Fixed NPE bug in SLACalculatorMemory for non-sla jobs causing test-failures
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1375
This addresses bug OOZIE-1375.
https://issues.apache.org/jira/browse/OOZIE-1375
Diffs (updated)
-----
trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java 1489572
trunk/core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java 1489572
trunk/core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java 1489572
trunk/core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java 1489572
trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 1489572
trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 1489572
trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java 1489572
trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java 1489572
trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 1489572
trunk/core/src/main/java/org/apache/oozie/sla/listener/SLAJobEventListener.java 1489572
trunk/core/src/main/java/org/apache/oozie/sla/service/SLAService.java 1489572
trunk/core/src/main/resources/oozie-default.xml 1489572
trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java 1489572
trunk/core/src/test/java/org/apache/oozie/event/TestEventQueue.java 1489572
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionGetJPAExecutor.java 1489572
trunk/core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java 1489572
trunk/core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java 1489572
trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1489572
Diff: https://reviews.apache.org/r/11295/diff/
Testing
-------
Testcase added. Other test files including XTestCase edited to enhance utility method createWfAction() to accept pending flag
Thanks,
Mona Chitnis
Re: Review Request: OOZIE-1375 Generate Job notification events for Workflow
Actions
Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11295/
-----------------------------------------------------------
(Updated June 4, 2013, 7:02 p.m.)
Review request for oozie.
Changes
-------
Uploaded final patch. There were some incorrect inclusions in patch revision 4, which show the r4-r5 deletion diff. Bbut those are corrected now and see r3-r5 diff for correct difference.
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1375
This addresses bug OOZIE-1375.
https://issues.apache.org/jira/browse/OOZIE-1375
Diffs (updated)
-----
trunk/client/src/main/java/org/apache/oozie/client/event/jms/MessageDeserializer.java 1489159
trunk/client/src/main/java/org/apache/oozie/client/event/message/WorkflowActionMessage.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java 1489159
trunk/core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java 1489159
trunk/core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java 1489159
trunk/core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java 1489159
trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 1489159
trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 1489159
trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java 1489159
trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java 1489159
trunk/core/src/main/java/org/apache/oozie/event/messaging/MessageFactory.java 1489159
trunk/core/src/main/java/org/apache/oozie/jms/JMSJobEventListener.java 1489159
trunk/core/src/main/resources/oozie-default.xml 1489159
trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java 1489159
trunk/core/src/test/java/org/apache/oozie/event/TestEventQueue.java 1489159
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionGetJPAExecutor.java 1489159
trunk/core/src/test/java/org/apache/oozie/jms/TestJMSJobEventListener.java 1489159
trunk/core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java 1489159
trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1489159
Diff: https://reviews.apache.org/r/11295/diff/
Testing
-------
Testcase added. Other test files including XTestCase edited to enhance utility method createWfAction() to accept pending flag
Thanks,
Mona Chitnis
Re: Review Request: OOZIE-1375 Generate Job notification events for Workflow
Actions
Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11295/
-----------------------------------------------------------
(Updated May 30, 2013, 6:49 p.m.)
Review request for oozie.
Changes
-------
Addressed Virag's comment. In ActionCheckX, generate-event only done for FAILED and START_MANUAL actions, hence avoiding duplicates for rerun actions via USER_RETRY or handleTransient
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1375
This addresses bug OOZIE-1375.
https://issues.apache.org/jira/browse/OOZIE-1375
Diffs (updated)
-----
trunk/client/src/main/java/org/apache/oozie/client/event/jms/MessageDeserializer.java 1487963
trunk/client/src/main/java/org/apache/oozie/client/event/message/WorkflowActionMessage.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java 1487963
trunk/core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java 1487963
trunk/core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java 1487963
trunk/core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java 1487963
trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 1487963
trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 1487963
trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java 1487963
trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java 1487963
trunk/core/src/main/java/org/apache/oozie/event/messaging/MessageFactory.java 1487963
trunk/core/src/main/java/org/apache/oozie/jms/JMSJobEventListener.java 1487963
trunk/core/src/main/resources/oozie-default.xml 1487963
trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java 1487963
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionGetJPAExecutor.java 1487963
trunk/core/src/test/java/org/apache/oozie/jms/TestJMSJobEventListener.java 1487963
trunk/core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java 1487963
trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1487963
Diff: https://reviews.apache.org/r/11295/diff/
Testing
-------
Testcase added. Other test files including XTestCase edited to enhance utility method createWfAction() to accept pending flag
Thanks,
Mona Chitnis
Re: Review Request: OOZIE-1375 Generate Job notification events for Workflow
Actions
Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11295/
-----------------------------------------------------------
(Updated May 30, 2013, 1:48 a.m.)
Review request for oozie.
Changes
-------
Addressed Virag's comments. Incorporated JMS related changes in patch.
Description (updated)
-------
https://issues.apache.org/jira/browse/OOZIE-1375
This addresses bug OOZIE-1375.
https://issues.apache.org/jira/browse/OOZIE-1375
Diffs (updated)
-----
trunk/client/src/main/java/org/apache/oozie/client/event/jms/MessageDeserializer.java 1487638
trunk/client/src/main/java/org/apache/oozie/client/event/message/WorkflowActionMessage.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java 1487638
trunk/core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java 1487638
trunk/core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java 1487638
trunk/core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java 1487638
trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 1487638
trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 1487638
trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java 1487638
trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java 1487638
trunk/core/src/main/java/org/apache/oozie/event/messaging/MessageFactory.java 1487638
trunk/core/src/main/java/org/apache/oozie/jms/JMSJobEventListener.java 1487638
trunk/core/src/main/resources/oozie-default.xml 1487638
trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java 1487638
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionGetJPAExecutor.java 1487638
trunk/core/src/test/java/org/apache/oozie/jms/TestJMSJobEventListener.java 1487638
trunk/core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java 1487638
trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1487638
Diff: https://reviews.apache.org/r/11295/diff/
Testing
-------
Testcase added. Other test files including XTestCase edited to enhance utility method createWfAction() to accept pending flag
Thanks,
Mona Chitnis
Re: Review Request: OOZIE-1375 Generate Job notification events for Workflow
Actions
Posted by Virag Kothari <vi...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11295/#review21168
-----------------------------------------------------------
-Action events need to be generated in ActionCheckX for START_MANUAL and FAILED
-In some cases, KillX sets the action status to KILLED but doesn't queue ActionKillX. In such cases, wf action events need to be generated there.
-The JMS job event listener is not configured to create workflow action messages. Will this be done in another JIRA? If so, we should not generate events for workflow action by default.
- Virag Kothari
On May 24, 2013, 10:01 p.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11295/
> -----------------------------------------------------------
>
> (Updated May 24, 2013, 10:01 p.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1375
>
> Note:
> 1. The SignalXCommand part of the patch will be rebased after the bug-fix for duplicate wf_job event generation
> 2. Looking for better solution than not changing method handleNonTransient from protected to public (visibleForTesting does not work outside packages)
>
>
> This addresses bug OOZIE-1375.
> https://issues.apache.org/jira/browse/OOZIE-1375
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java 1486119
> trunk/core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java 1486119
> trunk/core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java 1486119
> trunk/core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java 1486119
> trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 1486119
> trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java 1486119
> trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java 1486119
> trunk/core/src/main/resources/oozie-default.xml 1486119
> trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java 1486119
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionGetJPAExecutor.java 1486119
> trunk/core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java 1486119
> trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1486119
>
> Diff: https://reviews.apache.org/r/11295/diff/
>
>
> Testing
> -------
>
> Testcase added. Other test files including XTestCase edited to enhance utility method createWfAction() to accept pending flag
>
>
> Thanks,
>
> Mona Chitnis
>
>
Re: Review Request: OOZIE-1375 Generate Job notification events for Workflow
Actions
Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11295/
-----------------------------------------------------------
(Updated May 24, 2013, 10:01 p.m.)
Review request for oozie.
Changes
-------
Addressed comments. The current unit tests are enough to test commands and the event attributes. End-to-end test will follow
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1375
Note:
1. The SignalXCommand part of the patch will be rebased after the bug-fix for duplicate wf_job event generation
2. Looking for better solution than not changing method handleNonTransient from protected to public (visibleForTesting does not work outside packages)
This addresses bug OOZIE-1375.
https://issues.apache.org/jira/browse/OOZIE-1375
Diffs (updated)
-----
trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java 1486119
trunk/core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java 1486119
trunk/core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java 1486119
trunk/core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java 1486119
trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 1486119
trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java 1486119
trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java 1486119
trunk/core/src/main/resources/oozie-default.xml 1486119
trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java 1486119
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionGetJPAExecutor.java 1486119
trunk/core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java 1486119
trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1486119
Diff: https://reviews.apache.org/r/11295/diff/
Testing
-------
Testcase added. Other test files including XTestCase edited to enhance utility method createWfAction() to accept pending flag
Thanks,
Mona Chitnis
Re: Review Request: OOZIE-1375 Generate Job notification events for Workflow
Actions
Posted by Mona Chitnis <mo...@yahoo.in>.
> On May 22, 2013, 11:34 p.m., Rohini Palaniswamy wrote:
> > trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java, line 230
> > <https://reviews.apache.org/r/11295/diff/1/?file=295134#file295134line230>
> >
> > This might cause duplicate events
removed from here
> On May 22, 2013, 11:34 p.m., Rohini Palaniswamy wrote:
> > trunk/core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java, line 105
> > <https://reviews.apache.org/r/11295/diff/1/?file=295135#file295135line105>
> >
> > This condition is right
why this condition is right might be another discussion :). changed it back for this patch
> On May 22, 2013, 11:34 p.m., Rohini Palaniswamy wrote:
> > trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java, line 316
> > <https://reviews.apache.org/r/11295/diff/1/?file=295138#file295138line316>
> >
> > Duplicate events will be generated. Why not do in ActionEndXCommand ?
ActionEndX seems better. thanks
> On May 22, 2013, 11:34 p.m., Rohini Palaniswamy wrote:
> > trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java, line 301
> > <https://reviews.apache.org/r/11295/diff/1/?file=295140#file295140line301>
> >
> > Instead of calling StartX and SignalX, can we run a actual workflow and see if we get STARTED and SUCCESS (or FAILURE. Either one will do). Can keep suspend and kill cases as it is.
adding for checking actions events
- Mona
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11295/#review20921
-----------------------------------------------------------
On May 21, 2013, 4:09 a.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11295/
> -----------------------------------------------------------
>
> (Updated May 21, 2013, 4:09 a.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1375
>
> Note:
> 1. The SignalXCommand part of the patch will be rebased after the bug-fix for duplicate wf_job event generation
> 2. Looking for better solution than not changing method handleNonTransient from protected to public (visibleForTesting does not work outside packages)
>
>
> This addresses bug OOZIE-1375.
> https://issues.apache.org/jira/browse/OOZIE-1375
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java 1484558
> trunk/core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java 1484558
> trunk/core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java 1484558
> trunk/core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 1484558
> trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 1484558
> trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java 1484558
> trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java 1484558
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionGetJPAExecutor.java 1484558
> trunk/core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java 1484558
> trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1484558
>
> Diff: https://reviews.apache.org/r/11295/diff/
>
>
> Testing
> -------
>
> Testcase added. Other test files including XTestCase edited to enhance utility method createWfAction() to accept pending flag
>
>
> Thanks,
>
> Mona Chitnis
>
>
Re: Review Request: OOZIE-1375 Generate Job notification events for Workflow
Actions
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11295/#review20921
-----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java
<https://reviews.apache.org/r/11295/#comment43097>
This might cause duplicate events
trunk/core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java
<https://reviews.apache.org/r/11295/#comment43096>
This condition is right
trunk/core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java
<https://reviews.apache.org/r/11295/#comment43100>
Why public when you are extending it? protected should be fine.
trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java
<https://reviews.apache.org/r/11295/#comment43098>
Duplicate events will be generated. Why not do in ActionEndXCommand ?
trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java
<https://reviews.apache.org/r/11295/#comment43099>
Instead of calling StartX and SignalX, can we run a actual workflow and see if we get STARTED and SUCCESS (or FAILURE. Either one will do). Can keep suspend and kill cases as it is.
- Rohini Palaniswamy
On May 21, 2013, 4:09 a.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11295/
> -----------------------------------------------------------
>
> (Updated May 21, 2013, 4:09 a.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1375
>
> Note:
> 1. The SignalXCommand part of the patch will be rebased after the bug-fix for duplicate wf_job event generation
> 2. Looking for better solution than not changing method handleNonTransient from protected to public (visibleForTesting does not work outside packages)
>
>
> This addresses bug OOZIE-1375.
> https://issues.apache.org/jira/browse/OOZIE-1375
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java 1484558
> trunk/core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java 1484558
> trunk/core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java 1484558
> trunk/core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 1484558
> trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 1484558
> trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java 1484558
> trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java 1484558
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionGetJPAExecutor.java 1484558
> trunk/core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java 1484558
> trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1484558
>
> Diff: https://reviews.apache.org/r/11295/diff/
>
>
> Testing
> -------
>
> Testcase added. Other test files including XTestCase edited to enhance utility method createWfAction() to accept pending flag
>
>
> Thanks,
>
> Mona Chitnis
>
>